ARROW-742: [C++] std::wstring_convert exceptions handling #749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you rebase this (I rebased master after 0.4.1 vote passed)? |
Contributor
Author
|
@wesm , rebased |
wesm
reviewed
Jun 11, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
Can you add a unit test that hit this code path?
Contributor
Author
|
good idea, will add |
maxhora
force-pushed
the
ARROW-742
branch
2 times, most recently
from
fe383f4 to
1f517b0
Compare
Contributor
Author
|
@wesm , have added unit tests to throw range exception on using |
maxhora
force-pushed
the
ARROW-742
branch
4 times, most recently
from
f09a4e4 to
95dccb7
Compare
Contributor
Author
|
@wesm , this time ci builds should pass, could you please take a look, thanks! |
wesm
approved these changes
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.