ARROW-8950: [C++] Avoid HEAD when possible in S3 filesystem #7547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@bkietz Would like your input on the dataset changes. |
Member
Author
|
Note to self: instead of basing the default |
bkietz
approved these changes
Jun 25, 2020
Member
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
The dataset changes look fine to me
Member
There was a problem hiding this comment.
If it's not easily accessible from FileMetaData or so then this probably warrants a custom metadata field when writing _metadata.
Member
There was a problem hiding this comment.
Add FileSystem::OpenInput{Stream,File} overrides that accept a FileInfo parameter.
This can be used to optimize file opening when it the file size and existence
is already known. Concretely, avoids a HEAD request in S3.
pitrou
force-pushed
the
ARROW-8950-s3-open-file-info
branch
from
0004c69 to
eec1e8c
Compare
rdettai
reviewed
Jun 26, 2020
Comment on lines
406
to
407
| // Issue a HEAD Object to get the content-length and ensure any | ||
| // errors (e.g. file not found) don't wait until the first Read() call. |
Contributor
There was a problem hiding this comment.
This comment got a little bit out of sync with the code below ;-)
Contributor
|
Great! AWS is going to be surprised to see its worldwide S3 HEAD request rate drop by half overnight ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FileSystem::OpenInput{Stream,File} overrides that accept a FileInfo parameter.
This can be used to optimize file opening when it the file size and existence is already known. Concretely, avoids a HEAD request in S3.