ARROW-742: [C++] Use gflags from toolchain; Resolve cmake FindGFlags … #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and FindGTest Windows issues.
Member
|
This is breaking my local toolchain builds on Linux. Investigating |
Contributor
Author
|
@wesm , I have not tested changes on Linux, but maybe you need to remove all previously generated cmake files and run cmake again. Might ${GFLAGS_HOME} is not set correctly. |
Member
|
It was missing the static library suffix, fixed in #763 |
asfgit
pushed a commit
that referenced
this pull request
Jun 20, 2017
Minor regression introduced in #759 Author: Wes McKinney <wes.mckinney@twosigma.com> Closes #763 from wesm/ARROW-1129 and squashes the following commits: afc4bb6 [Wes McKinney] Fix gflags library name being searched for in toolchain builds on Linux/macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and FindGTest Windows issues.