ARROW-1123: Make jemalloc the default allocator #761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Ib03392431851773df3b59b2c9a4d9a7bd672d2cb
Change-Id: I1638282390f8f982eb1232de1cd3bfee3cb876d9
Change-Id: I862649f615e20cf98369f7dcbff89594686ff7c5
Change-Id: I7a847fec4e6f571311e52c35e52585ce1a8b2908
wesm
approved these changes
Jun 19, 2017
Member
wesm
left a comment
wesm
left a comment
There was a problem hiding this comment.
+1 modulo comment re: clang on Linux
| jemalloc_shared | ||
| ) | ||
| else() | ||
| if (CMAKE_COMPILER_IS_GNUCXX) |
Member
Author
There was a problem hiding this comment.
I'm not sure about that. I think it mostly impacts glibc versions that are installed on CentOS 5 and Ubuntu 12.04. On these ancient systems, I don't think we could build arrow using clang, thus I would not further investigate if this is specific to glibc or glibc+gcc.
Change-Id: I93c4c9e724830805836fb5923b251dd831093d17
Change-Id: I0d6c69f0b47a1379b0be85be89e909b776c12678
This reverts commit 44f0cfc.
Change-Id: I0bb5e3f58eb2cd1ab0a82b5cae476c95df94b4a9
Change-Id: I335cc9cb8ee3f621f045c8e06adc3ef26c863657
Member
|
Looks like this may be failing for only cpplint |
Change-Id: Ibd1e82c276c84de2bda03bf979870b081f6b9147
Change-Id: I98035ab8b975bbe9fe8e51969cdabbab7c8b42e8
Member
Author
|
Everything is fine expect some internals in gtest are broken with jemalloc. At the moment I'm not sure if the culprit is |
Member
Author
|
Green build: https://travis-ci.org/xhochy/arrow/builds/245418595 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ib03392431851773df3b59b2c9a4d9a7bd672d2cb