ARROW-9345: [C++][Dataset] Support casting scalars to dictionary scalars #7686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
For the C++ changes: you basically enabled casting to DictionaryScalar? (so that implicit casts in the dataset filter expression works?)
The enabled behaviour certainly looks good!
Member
Author
|
@jorisvandenbossche precisely |
pitrou
requested changes
Jul 9, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
LGTM, but can you add tests on the C++ side?
bkietz
force-pushed
the
9345-compare-with-dict-scalar
branch
from
a103849 to
54a2a67
Compare
Member
Author
|
@pitrou done, PTAL |
pitrou
reviewed
Jul 10, 2020
| } | ||
|
|
||
| TEST(TestDictionaryScalar, Basics) { | ||
| auto CheckIndexType = [&](const std::shared_ptr<DataType>& index_ty) { |
Member
There was a problem hiding this comment.
Ha, this function was never called?
pitrou
reviewed
Jul 10, 2020
| for (auto index_ty : all_dictionary_index_types()) { | ||
| auto ty = dictionary(index_ty, utf8()); | ||
| auto dict = checked_pointer_cast<StringArray>( | ||
| ArrayFromJSON(utf8(), R"(["alpha", "beta", "gamma"])")); |
Member
There was a problem hiding this comment.
Hmm, perhaps test for null as well?
pitrou
approved these changes
Jul 10, 2020
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
I don't know if you'd like to quickly add a test for null, otherwise please merge :-)
Member
Author
|
The null case doesn't hit the new code here, so I think I'll merge now and add more tests in follow up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable casting from Scalar DictionaryScalar, which allows InsertImplicitCasts to convert non-dict scalars embedded in filter expressions.