Skip to content

Conversation

@wesm
Copy link
Member

@wesm wesm commented Jul 19, 2020

This reverts commit f86c4db.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@emkornfield
Copy link
Contributor

I don't think we should revert this fully. This also fixes a bug with as_datetime flag. Per mailing list discussion let me see if I can get round trip this evening

@wesm
Copy link
Member Author

wesm commented Jul 20, 2020

OK. I won't be able to spend any time on it for several days at least

@emkornfield
Copy link
Contributor

I'll work on it tonight and try to get something out one way or another. Enjoy your time off

Copy link
Member

@kszucs kszucs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may revert this reversion, but merging to be able to cut 1.0.0-RC2.

@kszucs kszucs merged commit 23b19f6 into apache:master Jul 20, 2020
@BryanCutler
Copy link
Member

Let's just verify the Spark tests pass after the reverting.

@ursabot crossbow submit test-conda-python-3.8-spark-master

@BryanCutler
Copy link
Member

@ursabot crossbow submit test-conda-python-3.8-spark-master

@ursabot
Copy link

ursabot commented Jul 20, 2020

AMD64 Conda Crossbow Submit (#120385) builder failed.

Revision: 12840af

Clone Arrow: update (failure) step's stderr:

Cloning into '.'...
fatal: couldn't find remote ref refs/pull/7802/merge

@BryanCutler
Copy link
Member

@kszucs is there a way to kick off Spark integration tests right now on master?

@kszucs
Copy link
Member

kszucs commented Jul 20, 2020

@BryanCutler I already submitted them, the spark tests are still running https://github.com/ursa-labs/crossbow/branches/all?query=build-871

@kszucs
Copy link
Member

kszucs commented Jul 20, 2020

@BryanCutler seems like the spark tests are passing with the current master.

@BryanCutler
Copy link
Member

great, thanks @kszucs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants