ARROW-9706: [Java] Tests of TestLargeListVector correctly read offset #7943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiszk
changed the title
Contributor
|
+1, thanks. |
This was referenced Oct 30, 2020
pribor
pushed a commit
to GlobalWebIndex/arrow
that referenced
this pull request
Oct 24, 2025
This PR aims to correctly read offset as 8-byte in tests of `TestLargeListVector` while they currently read offset as only the first 4-byte. The current code works only for a little-endian platform. Closes apache#7943 from kiszk/ARROW-9706 Authored-by: Kazuaki Ishizaki <ishizaki@jp.ibm.com> Signed-off-by: Micah Kornfield <emkornfield@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to correctly read offset as 8-byte in tests of
TestLargeListVectorwhile they currently read offset as only the first 4-byte. The current code works only for a little-endian platform.