-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-9803: [Go] Add initial support for s390x #8011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
How about adding a CI job for s390x + Go on Travis CI as the first step like #7938 ? |
emkornfield
reviewed
Aug 19, 2020
Member
|
cc @kiszk |
kiszk
reviewed
Aug 20, 2020
Contributor
Author
daa2981 to
3dd764b
Compare
The initial support will allow the unit tests to pass on s390x.
Contributor
Author
|
Hello @emkornfield, wondering if this can be considered for merging? I've updated the PR to use a constant to check for endianess. Thanks. |
3dd764b to
5830b6e
Compare
kou
approved these changes
Nov 11, 2020
Member
kou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
Apr 20, 2021
As suggested by @kou in apache/arrow#8011, this will add a Travis CI job for Go on s390x. Closes #8047 from vivkong/master-travis-s390x Authored-by: Vivian Kong <vivkong@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This was referenced Jul 28, 2021
kou
pushed a commit
to apache/arrow-go
that referenced
this pull request
Aug 30, 2024
As suggested by @kou in apache/arrow#8011, this will add a Travis CI job for Go on s390x. Closes #8047 from vivkong/master-travis-s390x Authored-by: Vivian Kong <vivkong@gmail.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial support will allow the unit tests to pass on s390x.