ARROW-8296: [C++][Dataset] Add IpcFileWriteOptions#8389
Closed
bkietz wants to merge 14 commits intoapache:masterfrom
Closed
ARROW-8296: [C++][Dataset] Add IpcFileWriteOptions#8389bkietz wants to merge 14 commits intoapache:masterfrom
bkietz wants to merge 14 commits intoapache:masterfrom
Conversation
bkietz
force-pushed
the
8296-IpcFileWriteOptions
branch
from
638ad10 to
a2b587c
Compare
Member
Author
|
@kou not sure how to idiomatically propagate this change to GLib; it seems there's no way to raise an exception when setting a property? |
Member
|
I'll take a look it and push a fix. |
Member
|
Done. +1 on the GLib part. |
Member
Author
|
Thanks @kou! |
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
Should this also be exposed in python's dataset IpcFileWriteOptions ?
(can also look into pushing that)
cpp/src/arrow/dataset/file_ipc.cc
Outdated
Member
There was a problem hiding this comment.
Should this in theory only be done if we have multiple files / fragments? (like the issue we had for parquet)
Member
Author
There was a problem hiding this comment.
That sounds acceptable but I'd like to defer it to a follow up
nealrichardson
requested changes
Oct 9, 2020
Member
|
I'm fixing the R and then will merge |
nealrichardson
force-pushed
the
8296-IpcFileWriteOptions
branch
from
0c4d1e9 to
6467dc1
Compare
nealrichardson
approved these changes
Oct 9, 2020
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
+1; macOS Python failure is unrelated (failing on master)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.