Skip to content

ARROW-10251: [Rust] [DataFusion] MemTable::load() now loads partitions in parallel #8428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andygrove wants to merge 2 commits into from
Closed

ARROW-10251: [Rust] [DataFusion] MemTable::load() now loads partitions in parallel #8428

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48655f1
MemTable::load() now loads partitions in parallel
andygrove Oct 10, 2020
e5d3032
address feedback
andygrove Oct 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions rust/datafusion/src/datasource/memory.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ use crate::error::{ExecutionError, Result};
use crate::physical_plan::memory::MemoryExec;
use crate::physical_plan::ExecutionPlan;

use tokio::task::{self, JoinHandle};

/// In-memory table
pub struct MemTable {
schema: SchemaRef,
Expand Down Expand Up @@ -59,13 +61,24 @@ impl MemTable {
pub async fn load(t: &dyn TableProvider, batch_size: usize) -> Result<Self> {
let schema = t.schema();
let exec = t.scan(&None, batch_size)?;
let partition_count = exec.output_partitioning().partition_count();

let mut tasks = Vec::with_capacity(partition_count);
for partition in 0..partition_count {
let exec = exec.clone();
let task: JoinHandle<Result<Vec<RecordBatch>>> = task::spawn(async move {
let it = exec.execute(partition).await?;
it.into_iter()
.collect::<ArrowResult<Vec<RecordBatch>>>()
.map_err(ExecutionError::from)
});
tasks.push(task)
}

let mut data: Vec<Vec<RecordBatch>> =
Vec::with_capacity(exec.output_partitioning().partition_count());
for partition in 0..exec.output_partitioning().partition_count() {
let it = exec.execute(partition).await?;
let partition_batches = it.into_iter().collect::<ArrowResult<Vec<_>>>()?;
data.push(partition_batches);
let mut data: Vec<Vec<RecordBatch>> = Vec::with_capacity(partition_count);
for task in tasks {
let result = task.await.expect("MemTable::load could not join task")?;
data.push(result);
}

MemTable::new(schema.clone(), data)
Expand Down