ARROW-10321: [C++] Use check_cxx_source_compiles for AVX512 detect in compiler #8478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compiler Also build the SIMD file as ARROW_RUNTIME_SIMD_LEVEL. Signed-off-by: Frank Du <frank.du@intel.com>
frankdjx
force-pushed
the
avx512_runtime_level_build
branch
from
c1d41f4 to
bbe4bd3
Compare
Contributor
Author
|
Seems CI not related, push again |
nealrichardson
approved these changes
Oct 16, 2020
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
LGTM. I applied this patch on autobrew/homebrew-core#31 and it did the right things there.
kszucs
pushed a commit
that referenced
this pull request
Oct 19, 2020
… compiler Also build the SIMD files as ARROW_RUNTIME_SIMD_LEVEL. Signed-off-by: Frank Du <frank.du@intel.com> Closes #8478 from jianxind/avx512_runtime_level_build Authored-by: Frank Du <frank.du@intel.com> Signed-off-by: Neal Richardson <neal.p.richardson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also build the SIMD files as ARROW_RUNTIME_SIMD_LEVEL.
Signed-off-by: Frank Du frank.du@intel.com