ARROW-10631: [Rust] Fixed error in computing equality of fixed-sized binary. #8695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
LGTM. Logic now matches |
nevi-me
approved these changes
Nov 18, 2020
Contributor
nevi-me
left a comment
nevi-me
left a comment
There was a problem hiding this comment.
LGTM, can merge when CI passes (I restarted CI due to failure)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug on the equality for fixed-sized binary arrays. For these types, the number of bytes of a slot equals the specified size. However, we were not taking that into account when offsetting in number of slots in the comparison.