Skip to content

ARROW-10259: [Rust] Add custom metadata to Field #9025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mqy wants to merge 14 commits into from
Closed

ARROW-10259: [Rust] Add custom metadata to Field #9025

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3456eac
Add custom metadata to Field
mqy Dec 28, 2020
6582133
Test Field from/to JSON
mqy Dec 28, 2020
e2e2548
ArrowJsonField::from(): convert metadata
mqy Dec 28, 2020
9ae2f68
Update for json integration test
mqy Dec 30, 2020
06f5f2b
Support read field metadata from JSON oject(map)
mqy Dec 30, 2020
4750df9
try merge field metadata
mqy Dec 31, 2020
6dc7b3f
the test schema_equality(): add field metadata
mqy Dec 31, 2020
c775873
set_metadata -> with_metadata
mqy Jan 4, 2021
11c8357
clippy and doc
mqy Jan 4, 2021
4b10cb9
Enable generate_custom_metadata_case for Rust
mqy Jan 5, 2021
ec5a7af
Fix field metadata
mqy Jan 6, 2021
d70f6bd
ipc: build field metadata
mqy Jan 6, 2021
5d170a7
Add test data to convert_schema_round_trip
mqy Jan 6, 2021
a578fd6
Change signature of with_metadata
mqy Jan 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dev/archery/archery/integration/datagen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,8 +1568,7 @@ def _temp_path():

generate_custom_metadata_case()
.skip_category('Go')
.skip_category('JS')
.skip_category('Rust'), # TODO(ARROW-10259)
.skip_category('JS'),

generate_duplicate_fieldnames_case()
.skip_category('Go')
Expand Down
2 changes: 1 addition & 1 deletion rust/arrow/src/array/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2974,7 +2974,7 @@ mod tests {

#[test]
#[should_panic(
expected = "Data type List(Field { name: \"item\", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false }) is not currently supported"
expected = "Data type List(Field { name: \"item\", data_type: Int64, nullable: true, dict_id: 0, dict_is_ordered: false, metadata: None }) is not currently supported"
)]
fn test_struct_array_builder_from_schema_unsupported_type() {
let mut fields = Vec::new();
Expand Down
Loading