Skip to content

ARROW-11091: [Rust][DataFusion] Fix new clippy linting errors #9061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Dandandan wants to merge 4 commits into from
Closed

ARROW-11091: [Rust][DataFusion] Fix new clippy linting errors #9061

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ee242e0
Fix new clippy linting errors
Dandandan Dec 31, 2020
22067a4
Undo fmt
Dandandan Dec 31, 2020
7257ada
Fix tests
Dandandan Dec 31, 2020
69d17fd
Fix tests
Dandandan Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions rust/datafusion/src/logical_plan/plan.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -838,8 +838,10 @@ mod tests {
/// test earliy stopping in pre-visit
#[test]
fn early_stoping_pre_visit() {
let mut visitor = StoppingVisitor::default();
visitor.return_false_from_pre_in = OptionalCounter::new(2);
let mut visitor = StoppingVisitor {
return_false_from_pre_in: OptionalCounter::new(2),
..Default::default()
};
let plan = test_plan();
let res = plan.accept(&mut visitor);
assert!(res.is_ok());
Expand All @@ -852,8 +854,10 @@ mod tests {

#[test]
fn early_stoping_post_visit() {
let mut visitor = StoppingVisitor::default();
visitor.return_false_from_post_in = OptionalCounter::new(1);
let mut visitor = StoppingVisitor {
return_false_from_post_in: OptionalCounter::new(1),
..Default::default()
};
let plan = test_plan();
let res = plan.accept(&mut visitor);
assert!(res.is_ok());
Expand Down Expand Up @@ -907,8 +911,10 @@ mod tests {

#[test]
fn error_pre_visit() {
let mut visitor = ErrorVisitor::default();
visitor.return_error_from_pre_in = OptionalCounter::new(2);
let mut visitor = ErrorVisitor {
return_error_from_pre_in: OptionalCounter::new(2),
..Default::default()
};
let plan = test_plan();
let res = plan.accept(&mut visitor);

Expand All @@ -926,8 +932,10 @@ mod tests {

#[test]
fn error_post_visit() {
let mut visitor = ErrorVisitor::default();
visitor.return_error_from_post_in = OptionalCounter::new(1);
let mut visitor = ErrorVisitor {
return_error_from_post_in: OptionalCounter::new(1),
..Default::default()
};
let plan = test_plan();
let res = plan.accept(&mut visitor);
if let Err(e) = res {
Expand Down