-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11168: [Rust] [Doc] Fix cargo doc warnings #9133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jorgecarleitao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks a lot for taking this!
|
Turn to draft because there are cargo test errors. Back soon. |
2a6c4ec to
2e7d35c
Compare
e630a99 to
78eaa87
Compare
|
The build failed, no idea why does it build The merged commit c4ee536 also failed with same error. The problem is filed at https://issues.apache.org/jira/browse/ARROW-11184 @nevi-me I saw you just released parquet-format 2.7.0 hours ago, any idea? |
|
We released |
|
As pointed out by @carols10cents , this appears to have failed on master too: https://github.com/apache/arrow/actions?query=branch%3Amaster+workflow%3ARust https://github.com/apache/arrow/actions/runs/471629105 |
|
I'll look into this and try and get the build passing again |
|
This PR probably needs to be rebased to pick up the fix for #9138 |
9208930 to
8cf807f
Compare
@jorgecarleitao thanks for the review. It seems the CI is getting close to success, please review again. |
|
FWIW I tested this branch out locally and it worked really nicely -- no more warnings during build. Thanks @mqy ! |
The PR fixed cargo doc warnings (including the generated flatbuffer files), and corrected several typos.
To catch all possible cargo doc warnings, it looks like we have to run
cargo docfor both nightly and stable.I had filed an issue https://issues.apache.org/jira/browse/ARROW-11179 to address the cargo doc problem about generated flatbuffer files, hope this can be resolved soon. Currently, the patch is created as
format-0ed34c83.patchfor regen.sh.