Skip to content

ARROW-11231: [Python][Packaging] Enable mimalloc in wheels #9191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pitrou wants to merge 1 commit into from
Closed

ARROW-11231: [Python][Packaging] Enable mimalloc in wheels #9191

pitrou wants to merge 1 commit into from

Conversation

@pitrou
Copy link
Member

@pitrou pitrou commented Jan 13, 2021

No description provided.

@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2021

@github-actions crossbow -c ursacomputing/crossbow submit -g wheel

@pitrou pitrou requested a review from kszucs January 13, 2021 10:55
xhochy
xhochy approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

@kszucs
Copy link
Member

kszucs commented Jan 13, 2021

I applied this change in #9096 since I'm going to submit the wheel builds again to verify the changes there.

@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2021

Wheel builds triggered here:
https://github.com/ursacomputing/crossbow/branches/all?query=build-10

(note that we can't enable mimalloc on manylinux1 because it fails to compile)

@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2021

All passed on https://github.com/ursacomputing/crossbow/branches/all?query=build-10

@kszucs
Copy link
Member

kszucs commented Jan 13, 2021

Wheel builds triggered here:
https://github.com/ursacomputing/crossbow/branches/all?query=build-10

(note that we can't enable mimalloc on manylinux1 because it fails to compile)

I removed manylinux1 altogether.

@github-actions
Copy link

github-actions bot commented Jan 13, 2021

https://issues.apache.org/jira/browse/ARROW-11231

@github-actions
Copy link

github-actions bot commented Jan 13, 2021

Revision: fc067f8

Submitted crossbow builds: ursacomputing/crossbow @ actions-1

Task Status
wheel-manylinux1-cp36m Azure
wheel-manylinux1-cp37m Azure
wheel-manylinux1-cp38 Azure
wheel-manylinux1-cp39 Azure
wheel-manylinux2010-cp36m Azure
wheel-manylinux2010-cp37m Azure
wheel-manylinux2010-cp38 Azure
wheel-manylinux2010-cp39 Azure
wheel-manylinux2014-cp36m Azure
wheel-manylinux2014-cp37m Azure
wheel-manylinux2014-cp38 Azure
wheel-manylinux2014-cp39 Azure
wheel-osx-high-sierra-cp36m Github Actions
wheel-osx-high-sierra-cp37m Github Actions
wheel-osx-high-sierra-cp38 Github Actions
wheel-osx-high-sierra-cp39 Github Actions
wheel-osx-mavericks-cp36m Github Actions
wheel-osx-mavericks-cp37m Github Actions
wheel-osx-mavericks-cp38 Github Actions
wheel-osx-mavericks-cp39 Github Actions
wheel-win-cp36m Github Actions
wheel-win-cp37m Github Actions
wheel-win-cp38 Github Actions

@pitrou
Copy link
Member Author

pitrou commented Jan 13, 2021

Closing in favour of #9096.

@pitrou pitrou closed this Jan 13, 2021
@pitrou pitrou deleted the ARROW-11231-mimalloc-wheels branch January 13, 2021 18:42
@asfimport asfimport mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xhochy xhochy xhochy approved these changes

@kszucs kszucs Awaiting requested review from kszucs

Assignees

No one assigned

Labels

Component: Python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pitrou @kszucs @xhochy