ARROW-10735: [R] Remove arrow-without-arrow wrapping #9209
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key features:
arrowands3and potentially may get more of in the future with additional build-time features. Importantly, the wrapping with the fake implementation that we currently have for all functions has been encapsulated in such a way that we can choose whether to make some features always on or not.A single commit (a963e7c) adds an
ifstatement that effectively removes the arrow-without-arrow wrapping while still keeping S3 support optional (-2,795 lines of code).IMO we should go with this for a while, and if there is no further problems, we can remove the
ARROW_R_WITH_ARROWflags everywhere. Or if we decide to change our minds, we just remove theifstatement in codegen.R, nothing else to restore.In order to fully remove the flagging, we'd need to remove all occurrences of
ARROW_R_WITH_ARROWand also the special test handling of this, which includes another environment variable that is set in CI.