-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11420: [Rust] Added support to length of Binary and List. #9353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
unsafe.
Codecov Report
@@ Coverage Diff @@
## master #9353 +/- ##
==========================================
- Coverage 81.97% 81.95% -0.03%
==========================================
Files 216 216
Lines 53227 53270 +43
==========================================
+ Hits 43633 43657 +24
- Misses 9594 9613 +19
Continue to review full report at Codecov.
|
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really nice @jorgecarleitao 👍
|
@jorgecarleitao -- this one needs a rebase and then I think it is ready to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.null_buffer().cloned() ?
d4608a9 to
356c300
Compare
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went through this again. I think it is good -- is there anything else you want to add @jorgecarleitao (tests? ) or shall we merge it?
|
@jorgecarleitao I think this one is ready to go -- it just needs a rebase and then merge |
|
The Apache Arrow Rust community is moving the Rust implementation into its own dedicated github repositories arrow-rs and arrow-datafusion. It is likely we will not merge this PR into this repository Please see the mailing-list thread for more details We expect the process to take a few days and will follow up with a migration plan for the in-flight PRs. |
This adds
[Large]Binaryand[Large]Listsupport to length.Also removes unneeded
unsafeenabled by the recent PR #9215.