ARROW-11457: [Rust] Make string comparisson kernels generic over Utf8 and LargeUtf8 #9362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgecarleitao
approved these changes
Jan 29, 2021
Member
jorgecarleitao
left a comment
jorgecarleitao
left a comment
There was a problem hiding this comment.
Thanks a lot, @ritchie46 , looks perfect to me.
alamb
approved these changes
Jan 31, 2021
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
👍 Thanks @ritchie46 the only thing that would improve this PR would be a test or two to ensure someone doesn't cause this functionality to regress in the future.
Contributor
Author
Done! |
Contributor
|
https://issues.apache.org/jira/browse/ARROW-11428 is something related to |
alamb
changed the title
This was referenced Feb 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the existing comparisson kernels that operate on
StringArraygeneric over bothStringArrayandLargeStringArray.