Skip to content

Conversation

@jwdeitch
Copy link

@jwdeitch jwdeitch commented Feb 7, 2021

No description provided.

@github-actions
Copy link

github-actions bot commented Feb 7, 2021

@codecov-io
Copy link

codecov-io commented Feb 7, 2021

Codecov Report

Merging #9437 (927e2c4) into master (a321cde) will decrease coverage by 0.00%.
The diff coverage is 72.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9437      +/-   ##
==========================================
- Coverage   82.14%   82.14%   -0.01%     
==========================================
  Files         232      232              
  Lines       54150    54193      +43     
==========================================
+ Hits        44484    44516      +32     
- Misses       9666     9677      +11     
Impacted Files Coverage Δ
rust/datafusion/src/logical_plan/expr.rs 80.04% <0.00%> (-0.19%) ⬇️
...datafusion/src/physical_plan/string_expressions.rs 70.21% <54.16%> (-16.75%) ⬇️
rust/datafusion/src/physical_plan/functions.rs 72.75% <100.00%> (+0.46%) ⬆️
rust/datafusion/tests/sql.rs 99.85% <100.00%> (+<0.01%) ⬆️
rust/parquet/src/encodings/encoding.rs 95.05% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb7f053...927e2c4. Read the comment docs.

@seddonm1
Copy link
Contributor

seddonm1 commented Feb 8, 2021

Hi @jwdeitch

This overlaps with #9243 so maybe we can integrate the tests into a single PR?

@jwdeitch
Copy link
Author

jwdeitch commented Feb 9, 2021

@seddonm1 ah good call, will do!

@jwdeitch jwdeitch closed this Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants