-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11624: [Rust] Move Arrow benchmarks to its own crate #9493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
07c2600
Move benches to its own crate
Dandandan 6b09cc4
Add licence
Dandandan 6db1c5a
Add to prepare-test
Dandandan 679f294
Reorder
Dandandan cac4427
Remove?
Dandandan d621981
Add to both
Dandandan 466f4b0
Fix
Dandandan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| [package] | ||
| name = "arrow-benches" | ||
| description = "Apache Arrow micro benchmarks" | ||
| version = "4.0.0-SNAPSHOT" | ||
| edition = "2018" | ||
| authors = ["Apache Arrow <dev@arrow.apache.org>"] | ||
| homepage = "https://github.com/apache/arrow" | ||
| repository = "https://github.com/apache/arrow" | ||
| license = "Apache-2.0" | ||
|
|
||
| [dependencies] | ||
| arrow = { path = "../arrow", version = "4.0.0-SNAPSHOT"} | ||
|
|
||
| [dev-dependencies] | ||
| criterion = "0.3" | ||
| rand = "0.7" | ||
| chrono = "0.4" | ||
|
|
||
| [[bench]] | ||
| name = "aggregate_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "array_from_vec" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "builder" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "buffer_bit_ops" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "boolean_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "arithmetic_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "cast_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "comparison_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "filter_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "take_kernels" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "length_kernel" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "sort_kernel" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "csv_writer" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "json_reader" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "equal" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "array_slice" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "concatenate_kernel" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "mutable_array" | ||
| harness = false | ||
|
|
||
| [[bench]] | ||
| name = "buffer_create" | ||
| harness = false |
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I was imagining something more like adding a
So then if one wanted to have the benches built they could run a command like
cargo bench --features benchesor somethingThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be interesting to try out something like that out. It will keep the dev flow more similar to what we have now while reducing the compile times when you don't want to run any benchmarks.
@jorgecarleitao would something like this work for you?