-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11626: [Rust][DataFusion] Move [DataFusion] examples to own project #9494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
da49546
Move datafusion examples to own project
Dandandan 73235ba
Remove dependencies
Dandandan 225a684
Fix CI
Dandandan cebc63d
Add to prepare-test
Dandandan f776ce9
Move arrow-flight
Dandandan ac2f2ee
Use latest version
Dandandan 4626305
Add to both tests
Dandandan 94dadb0
Fix
Dandandan 835bc47
Add publish=false
Dandandan 19884c3
Update .github/workflows/rust.yml
Dandandan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| [package] | ||
| name = "datafusion-examples" | ||
| description = "DataFusion usage examples" | ||
| version = "4.0.0-SNAPSHOT" | ||
| homepage = "https://github.com/apache/arrow" | ||
| repository = "https://github.com/apache/arrow" | ||
| authors = ["Apache Arrow <dev@arrow.apache.org>"] | ||
| license = "Apache-2.0" | ||
| keywords = [ "arrow", "query", "sql" ] | ||
| edition = "2018" | ||
| publish = false | ||
|
|
||
|
|
||
| [dev-dependencies] | ||
| datafusion = { path = "../datafusion" } | ||
Dandandan marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| arrow = { path = "../arrow" } | ||
| prost = "0.7" | ||
| arrow-flight = { path = "../arrow-flight" } | ||
| tonic = "0.4" | ||
| tokio = { version = "1.0", features = ["macros", "rt", "rt-multi-thread", "sync"] } | ||
| futures = "0.3" | ||
| num_cpus = "1.13.0" | ||
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -75,9 +75,6 @@ lazy_static = { version = "^1.4.0", optional = true } | |
| rand = "0.8" | ||
| criterion = "0.3" | ||
| tempfile = "3" | ||
| prost = "0.7" | ||
|
||
| arrow-flight = { path = "../arrow-flight", version = "4.0.0-SNAPSHOT" } | ||
| tonic = "0.4" | ||
| doc-comment = "0.3" | ||
|
|
||
| [[bench]] | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @andygrove -- I am not sure what you think about possibly releasing the examples as a crate of their own. I personally think it would be necessary. However perhaps it would be the right way to to eventually to somehow link to the example code from the docs.rs page https://docs.rs/datafusion/3.0.0/datafusion/
I filed this JIRA https://issues.apache.org/jira/browse/ARROW-11863 to track that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd lean on not publishing by default, so I'd prefer a
publish = falseon the Cargo file. I support clarifying this as part of ARROW-11863 @alamb.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
publish = false.The examples are currently also not on https://docs.rs/datafusion/3.0.0/datafusion/ I think - agree that it would be very useful.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another (better) option would be to link at a versioned url (based on published version)
https://github.com/apache/arrow/tree/apache-arrow-3.0.0