-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11738: [Rust][DataFusion] Fix Concat and Trim Functions #9551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @seddonm1 -- I will plan to review this over the next few days |
|
@Dandandan I can add |
|
@Dandandan I have added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alphabetically, this should be after concat?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, my VSCode sorting treats _ before ". fixed 👍
Dandandan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I think from time to time we will can check on the status of the tpch queries. Feel free to split the PRs in the way you think makes sense @seddonm1 👍
@Dandandan basically the string functions PR is so big even splitting like this makes a big difference and allows applying some of the foundational components (see the testing) required for the rest. So if this helps unblock you then thats a good thing :D |
alamb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
This PR sadly does need a rebase |
|
thanks @alamb rebased 👍 |
|
Integration test failure looks like https://issues.apache.org/jira/browse/ARROW-11717, so ignoring |
This PR is a child of #9243
It does a few things that are hard to separate:
concatandtrimfunctions to be in line with the Postgres implementations@alamb @jorgecarleitao
please review but merging will be dependent on #9507