ARROW-11580: [C++] Add CMake option ARROW_DEPENDENCY_SOURCE=VCPKG #9553
Conversation
|
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
|
Revision: 17c32d4 Submitted crossbow builds: ursacomputing/crossbow @ actions-172
|
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
(My review isn't completed yet... I'll continue later.)
|
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
|
Revision: f5c21b3 Submitted crossbow builds: ursacomputing/crossbow @ actions-173
|
|
FYI, I have not attempted to thoroughly test and fix debug builds with vcpkg-installed dependencies, but I plan to do that in ARROW-11796. |
|
@kou let me know if there is anything I can do to help you complete your review. Thank you! |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
It almost looks good to me!
I'm not sure many CACHE are really needed.
|
Oh, sorry for my late review... |
Co-authored-by: Sutou Kouhei <kou@cozmixng.org>
|
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
|
Revision: d7f0e22 Submitted crossbow builds: ursacomputing/crossbow @ actions-178
|
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
We can merge this once CI is green.
|
@github-actions crossbow submit test-build-vcpkg-win wheel-manylinux2010-cp36m wheel-windows-cp36m |
|
Revision: 2e6905a Submitted crossbow builds: ursacomputing/crossbow @ actions-180
|
2 participants
This builds upon ARROW-11340 and makes it simpler to use vcpkg for dependencies.
Previously, to use vcpkg it was necessary to specify:
-DARROW_DEPENDENCY_SOURCE=SYSTEM-DCMAKE_TOOLCHAIN_FILE=/path/to/vcpkg.cmake-DVCPKG_TARGET_TRIPLET=xxx-yyy-zzz*_MSVC_*variables on Windows*_ROOT,*_LIB, and*_INCLUDEvariables in some cases-D_VCPKG_INSTALLED_DIR=/path/to/vcpkg/installed/dirin some casesNow all that is necessary is:
-DARROW_DEPENDENCY_SOURCE=VCPKGOther variables are now optional and can be specified to override default behaviors.
After this is merged, I will make additional updates to the docs, focusing initially on Windows (ARROW-11336).