Skip to content

Conversation

@BryanCutler
Copy link
Member

Adding type param getters to NullableValueVectors as a convenience over getting the Field and casting the type to get the param values. These getters just call the inner vector FixedValueVectors which also contains these param values. Since NullableValueVectors does not use the param variables except during initialization they are removed here.

@BryanCutler
Copy link
Member Author

@icexelloss
Copy link
Contributor

icexelloss commented Aug 29, 2017

This looks fine to me. We should probably add this too all vector templates:

  • VariableLengthVectors.java
  • FixedValueVectors.java
  • NullableValueVetors.java

@wesm
Copy link
Member

wesm commented Aug 29, 2017

@icexelloss there has been some discussion about this in the JIRA: https://issues.apache.org/jira/browse/ARROW-1361

@siddharthteotia
Copy link
Contributor

LGTM. However, we may want to revisit this once we start working on https://issues.apache.org/jira/browse/ARROW-1463

@BryanCutler
Copy link
Member Author

Thanks @icexelloss and @siddharthteotia . Yes, I'll hold off on this for now.

@icexelloss
Copy link
Contributor

Hey @BryanCutler seems like the changes here can be made on the new vectors now. Do you still want to add the methods?

@BryanCutler
Copy link
Member Author

BryanCutler commented Feb 2, 2018 via email

@icexelloss
Copy link
Contributor

Yeah I think DecimalVector should have getPrecision() and getScale() methods. Unfortunately(?) now we need to do this on a vector by vector basis. FixedSizeListVector already has getListSize(). I checked other vectors seems to be fine.

@BryanCutler
Copy link
Member Author

Closing this, now it will have to be done on the individual vector classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants