Skip to content

Conversation

@pachadotdev
Copy link
Contributor

No description provided.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW

Then could you also rename pull request title in the following format?

ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@pachadotdev pachadotdev changed the title first informative error msg for lz4 error ARROW-11766: [R] first informative error msg for lz4 error Mar 18, 2021
@github-actions
Copy link

@nealrichardson
Copy link
Member

Please rename the PR title to match the JIRA title

@pachadotdev pachadotdev changed the title ARROW-11766: [R] first informative error msg for lz4 error ARROW-11766: [R] Improve the experience for installing arrow on linux Mar 19, 2021
@nealrichardson nealrichardson changed the title ARROW-11766: [R] Improve the experience for installing arrow on linux ARROW-11766: [R] Better handling for missing compression codecs on Linux Mar 26, 2021
@pachadotdev
Copy link
Contributor Author

@github-actions crossbow submit test-r-minimal-build

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Revision: ea5949e

Submitted crossbow builds: ursacomputing/crossbow @ actions-252

Task Status
test-r-minimal-build Azure

@pachadotdev
Copy link
Contributor Author

@github-actions crossbow submit test-r-minimal-build

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Revision: 9169e0c

Submitted crossbow builds: ursacomputing/crossbow @ actions-253

Task Status
test-r-minimal-build Azure

Copy link
Member

@jonkeane jonkeane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, this PR is improving. I have some comments, suggestions, and changes. It also would be good for you to purposely break / take the validation out (but keep your test(s) in place) and run the crossbow job to prove that that job will fail and you are testing what you think you're testing and then add them back in.

It also looks like you're going to need to rebase before you can merge it in. If you do the rebasing now you'll also have the benefit of the PR checks running automatically for you to catch if there's anything amiss in the branch.

Pachamaltese and others added 6 commits April 2, 2021 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants