-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-11766: [R] Better handling for missing compression codecs on Linux #9743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? Then could you also rename pull request title in the following format? See also: |
|
Please rename the PR title to match the JIRA title |
|
@github-actions crossbow submit test-r-minimal-build |
|
Revision: ea5949e Submitted crossbow builds: ursacomputing/crossbow @ actions-252
|
…when lz4/snappy is not installed
|
@github-actions crossbow submit test-r-minimal-build |
|
Revision: 9169e0c Submitted crossbow builds: ursacomputing/crossbow @ actions-253
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, this PR is improving. I have some comments, suggestions, and changes. It also would be good for you to purposely break / take the validation out (but keep your test(s) in place) and run the crossbow job to prove that that job will fail and you are testing what you think you're testing and then add them back in.
It also looks like you're going to need to rebase before you can merge it in. If you do the rebasing now you'll also have the benefit of the PR checks running automatically for you to catch if there's anything amiss in the branch.
Co-authored-by: Neal Richardson <neal.p.richardson@gmail.com>
Co-authored-by: Jonathan Keane <jkeane@gmail.com>
No description provided.