Skip to content

ARROW-11703: [R] Implement dplyr::arrange() #9745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ianmcook wants to merge 49 commits into from
Closed

ARROW-11703: [R] Implement dplyr::arrange() #9745

ianmcook wants to merge 49 commits into from

Conversation

@ianmcook
Copy link
Member

@ianmcook ianmcook commented Mar 18, 2021 •
edited
Loading

  • Implement SortIndices R6 method for ArrowTabular
  • Add SortIndices tests
  • Implement dplyr::arrange()
  • Add dplyr::arrange() tests
  • Create follow-up issues

There also are a some indirectly related opportunistic additions here, including:

  • SortIndices R6 methods and sort() S3 methods for Array, ChunkedArray with tests

@github-actions
Copy link

github-actions bot commented Mar 18, 2021

https://issues.apache.org/jira/browse/ARROW-11703

@ianmcook
Copy link
Member Author

ianmcook commented Mar 18, 2021

sort() is an S3 generic so it was easy to implement methods for the ArrowDatum types. It would nice to implement order() methods too, but order() is not an S3 generic. Looking at what the bit64 developer did to implement sort(), I think it is not worthwhile here.

nealrichardson
nealrichardson reviewed Mar 19, 2021
View reviewed changes
nealrichardson
nealrichardson reviewed Mar 23, 2021
View reviewed changes
ianmcook added 24 commits March 24, 2021 10:30
@ianmcook
Implement SortIndices method for Table, RecordBatch, Array, ChunkedArray
5a9cb90
@ianmcook
Fix SortIndices for ChunkedArray
d47cfd0
@ianmcook
Implement sort() method for ArrowDatum types
67d2199
@ianmcook
Disallow unsupported na.last options in Array and ChunkedArray sort()
deef9a3
@ianmcook
Add test data for sort tests
e269669
@ianmcook
Add compute sorting tests
7001927
@ianmcook
Fix unsigned/signed compare error
c5bf536
@ianmcook
Implement dplyr::arrange() for ArrowTabular
3fa4125
@ianmcook
Add arrange() tests
5c8b70e
@ianmcook
Define sort method for ArrowDatum instead of Array and ChunkedArray
ecd5bf7
@ianmcook
Improve tests
aad31cb
@ianmcook
Rename get_field_name -> get_field_name_of_array_ref
3fe0c51
@ianmcook
Support na.last in sort.ArrowDatum
1bc1806
@ianmcook
Fix failing tests
154cac6
@ianmcook
Fix failing tests
4e88023
@ianmcook
Fix failing tests
eeb1db0
@ianmcook
Support expressions in arrange()
82dc4ff
@ianmcook
Do arrange() locally when unsupported expression
27025e0
@ianmcook
Update tests
791064e
@ianmcook
Add TODO
9593e89
@ianmcook
Support arrange(.by_group = TRUE)
6604144
@ianmcook
Fix and add tests
50c6992
@ianmcook
Handle case when empty dots and .group_by = TRUE
9e87b26
@ianmcook
More tests for edge cases
d7dba8e
@nealrichardson nealrichardson changed the title ARROW-11703: [R] Implement dplyr::arrange() [WIP] ARROW-11703: [R] Implement dplyr::arrange() Mar 24, 2021
@ianmcook ianmcook marked this pull request as ready for review March 24, 2021 14:55
nealrichardson
nealrichardson reviewed Mar 24, 2021
View reviewed changes
nealrichardson
nealrichardson reviewed Mar 25, 2021
View reviewed changes
nealrichardson
nealrichardson reviewed Mar 25, 2021
View reviewed changes
nealrichardson
nealrichardson reviewed Mar 25, 2021
View reviewed changes
@asfimport asfimport mentioned this pull request Mar 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nealrichardson nealrichardson nealrichardson approved these changes

Assignees

No one assigned

Labels

Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ianmcook @nealrichardson