ARROW-11336: [C++][Doc] Improve Developing on Windows docs #9855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcook
changed the title
Member
Author
|
@bkietz please review |
Member
jorisvandenbossche
left a comment
jorisvandenbossche
left a comment
There was a problem hiding this comment.
I don't use windows, so can't comment on the content ;) But was just reading through (looks good!), and have one small sphinx suggestion
pitrou
reviewed
Apr 1, 2021
Member
pitrou
left a comment
pitrou
left a comment
There was a problem hiding this comment.
Looks good generally, two small comments.
bkietz
requested changes
Apr 6, 2021
Member
bkietz
left a comment
bkietz
left a comment
There was a problem hiding this comment.
minor comments, otherwise this looks good
bkietz
approved these changes
Apr 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.