ARROW-12186: [Rust][DataFusion] Fix regexp_match test #9874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Wow, sorry - what an oversight on my part! Thanks for fixing this. |
Contributor
|
Something about the macos test failed: https://github.com/apache/arrow/runs/2250992295?check_suite_focus=true retriggered running the tests and will merge this in if they pass Thanks @seddonm1 |
alamb
approved these changes
Apr 2, 2021
Contributor
|
The integration test failed due to out of space on the executor and the failure was not related to this PR -- we have since fixed that in #9879. |
pachadotdev
pushed a commit
to pachadotdev/arrow
that referenced
this pull request
Apr 5, 2021
This just moves the tests to allow the feature-flag to be used and pass this kind of test (where previously it would fail) ```bash cargo test --no-default-features --features cli ``` Closes apache#9874 from seddonm1/regexp_match_test Authored-by: Mike Seddon <seddonm1@gmail.com> Signed-off-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just moves the tests to allow the feature-flag to be used and pass this kind of test (where previously it would fail)
cargo test --no-default-features --features cli