Skip to content

ARROW-11338: [R] Bindings for quantile and median#9875

Closed
ianmcook wants to merge 13 commits intoapache:masterfrom
ianmcook:ARROW-11338
Closed

ARROW-11338: [R] Bindings for quantile and median#9875
ianmcook wants to merge 13 commits intoapache:masterfrom
ianmcook:ARROW-11338

Conversation

@ianmcook
Copy link
Copy Markdown
Member

@ianmcook ianmcook commented Apr 2, 2021

This adds quantile() and median() methods for ArrowDatum

Comment thread r/R/compute.R
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2021

Comment thread r/NAMESPACE
Comment thread r/R/compute.R
Comment thread r/R/compute.R Outdated
Comment thread r/R/compute.R Outdated
@ianmcook ianmcook changed the title ARROW-11338: [R] Bindings for quantile and median [WIP] ARROW-11338: [R] Bindings for quantile and median Apr 5, 2021
Copy link
Copy Markdown
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two last questions but this is looking good, nice job

Comment thread r/R/compute.R
Comment thread r/tests/testthat/test-compute-aggregate.R Outdated
Copy link
Copy Markdown
Member

@nealrichardson nealrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants