-
Notifications
You must be signed in to change notification settings - Fork 4k
ARROW-12224: [Rust] Use stable rust for no default test, clean up CI tests #9904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
aa5bd35 to
dad8209
Compare
Codecov Report
@@ Coverage Diff @@
## master #9904 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 256 256
Lines 60186 60186
=======================================
Hits 49780 49780
Misses 10406 10406 Continue to review full report at Codecov.
|
jorgecarleitao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks a lot!
|
|
||
| # build the library, a compilation step used by multiple steps below | ||
| linux-build-lib: | ||
| name: AMD64 Debian 10 Rust ${{ matrix.rust }} build libraries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kszucs has raised in the past the he would prefer to have the same names as other implementations.
pinging him here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hint @jorgecarleitao -- will wait for @kszucs to weigh in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this convention to remain consistent with the rest of the workflows (C++, Python, Ruby, etc.).
I'm fine with using a different naming convention too if you think that helps distinguishing the builds.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it will help. Let's try this way and see how we like it. Thanks @kszucs 👍
Rationale
RUSTFLAGSChanges
RUSTFLAGSNote
This could be three individual PRs, but I wanted to avoid the overhead of three separate JIRA tickets and juggling several concurrent potentially conflicting PRs. I will break it into three individual ones however if reviewers want.