AVRO-3871: Support nested lists/maps in BlockingDirectBinaryEncoder #2732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
changed the title
Fokko
force-pushed
the
fd-support-nested-maps-arrays
branch
2 times, most recently
from
12d44d1 to
c1be917
Compare
Fokko
force-pushed
the
fd-support-nested-maps-arrays
branch
from
c1be917 to
1b08260
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SpecificData.Array<java.lang.String> ga0 = (a0 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.lang.String>) a0 | ||
| : null); | ||
| SpecificData.Array<String> ga0 = (a0 instanceof SpecificData.Array ? (SpecificData.Array<String>) a0 : null); |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| } else | ||
| a2.clear(); | ||
| SpecificData.Array<java.util.List<String>> ga2 = (a2 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.util.List<String>>) a2 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| e2 = a3; | ||
| } else | ||
| a3.clear(); | ||
| SpecificData.Array<String> ga3 = (a3 instanceof SpecificData.Array ? (SpecificData.Array<String>) a3 : null); |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| SpecificData.Array<java.lang.String> ga0 = (a0 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.lang.String>) a0 | ||
| : null); | ||
| SpecificData.Array<String> ga0 = (a0 instanceof SpecificData.Array ? (SpecificData.Array<String>) a0 : null); |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| } else | ||
| a2.clear(); | ||
| SpecificData.Array<java.util.List<String>> ga2 = (a2 instanceof SpecificData.Array | ||
| ? (SpecificData.Array<java.util.List<String>>) a2 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
| e2 = a3; | ||
| } else | ||
| a3.clear(); | ||
| SpecificData.Array<String> ga3 = (a3 instanceof SpecificData.Array ? (SpecificData.Array<String>) a3 |
Check warning
Code scanning / CodeQL
Cast from abstract to concrete collection
jbonofre
approved these changes
May 3, 2024
Contributor
Author
|
Thanks @jbonofre 🙌 |
Fokko
added a commit
to Fokko/avro
that referenced
this pull request
May 5, 2024
…pache#2732) * Support nested lists/maps * Add some tests
Fokko
added a commit
to Fokko/avro
that referenced
this pull request
May 7, 2024
…pache#2732) * Support nested lists/maps * Add some tests
RanbirK
pushed a commit
to RanbirK/avro
that referenced
this pull request
May 13, 2024
…pache#2732) * Support nested lists/maps * Add some tests
Fokko
added a commit
that referenced
this pull request
Jun 11, 2024
* AVRO-3983: Allow setting a custom encoder in DataFileWriter (#2874) * AVRO-3871: Add blocking direct binary encoder (#2521) * Java: Add blocking direct binary encoder * Optimize * Comments and more tests * Comments and more tests * Fix rat check * AVRO-3871: Support nested lists/maps in BlockingDirectBinaryEncoder (#2732) * Support nested lists/maps * Add some tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
Verifying this change
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation