Skip to content

[Task]: Re-use BatchConverterTest for different implementations #22950

@TheNeuralBit

Description

@TheNeuralBit

What needs to happen?

We have BatchConverterTest in batch.py, which is used to test the list and numpy implementations. As more BatchConverter implementations are added they will need to add tests that are almost identical to this one, with a few alterations:

  • The test data, currently handled with parameterized_class.
  • Possibly a custom equality check (e.g. pd.testing.assert_frame_equal for pandas)

We should make it possible to re-use the tests in BatchConverterTest without copy-pasting it, as this will lead to fragmentation.

Issue Priority

Priority: 2

Issue Component

Component: dsl-dataframe

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions