[BEAM-1080] Skip tests that required GCP credentials #10890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

aaltay merged 1 commit into master from aaltay-patch-1

Feb 19, 2020

Member

aaltay commented Feb 18, 2020

Follow up to #10829

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

Choose reviewer(s) and mention them in a comment (R: @username).
Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
Update CHANGES.md with noteworthy changes.
If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang	SDK	Apex	Dataflow	Flink	Gearpump	Samza	Spark
Go		---	---		---	---
Java
Python		---			---	---
XLang	---	---	---		---	---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.


          [BEAM-1080] Skip tests that required GCP credentials

0f9acce

probot-autolabeler bot added the python label

Member Author

aaltay commented Feb 18, 2020

Contributor

y1chi commented Feb 18, 2020

Thanks, should we reopen BEAM-1080?

angoenka approved these changes

View reviewed changes

Contributor

angoenka left a comment

LGTM

Member Author

aaltay commented Feb 18, 2020

Thanks, should we reopen BEAM-1080?

Re-opened. Not sure why it was resolved.

y1chi approved these changes

View reviewed changes

Contributor

y1chi left a comment

LGTM.

Member Author

aaltay commented Feb 18, 2020

retest this please

aaltay merged commit a76a62d into master

aaltay deleted the aaltay-patch-1 branch

February 19, 2020 00:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels