Repeatedly#onFire should clear all finished bits #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, Repeatedly#onFire only cleared the finished bits associated with the root of the sub-tree, as demonstrated by the new unit tests. This led to problems with AfterFirst#shouldFire, which checked to see if any of the sub-triggers have their finished bits set. Now, Repeatedly#onFire calls #resetTree, which clears all the finished bits in the entire sub-tree.
Contributor
Author
Member
|
LGTM. Merging. |
kennknowles
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Apr 1, 2016
iemejia
referenced
this pull request
in iemejia/beam
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
apache#98 [euphoria-flink] Do not allow object re-use
kennknowles
pushed a commit
to kennknowles/beam
that referenced
this pull request
Jun 1, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
becketqin
pushed a commit
to becketqin/beam
that referenced
this pull request
Feb 8, 2024
LISAMZA-36419: support offspring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, Repeatedly#onFire only cleared the finished bits associated
with the root of the sub-tree, as demonstrated by the new unit tests.
This led to problems with AfterFirst#shouldFire, which checked to see if
any of the sub-triggers have their finished bits set.
Now, Repeatedly#onFire calls #resetTree, which clears all the finished
bits in the entire sub-tree.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
mvn clean verify. (Even better, enableTravis-CI for on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.