[BEAM-9379] vendor calcite 1.22.0 #11058

vectorijk · 2020-03-05T18:41:55Z

vendor calcite 1.22.0

Lang	SDK	Apex	Dataflow	Gearpump	Samza
Go		---	---	---	---
Java
Python		---		---	---
XLang	---	---	---	---	---

Pre-Commit Tests Status (on master branch)

---	Java	Python	Go	Website
Non-portable
Portable	---		---	---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

vectorijk · 2020-03-05T18:44:46Z

R: @amaliujia @apilloud

amaliujia · 2020-03-05T18:54:01Z

As I recall, we can merge this PR first and then start a vendor calcite release, right?

amaliujia · 2020-03-05T18:55:00Z

Run Gradle Build

lukecwik · 2020-03-05T18:57:54Z

Please run the linkage checker to see if there were any changes.

Optionally, reduce the set of linkage errors being reported.

vectorijk · 2020-03-05T21:34:41Z

rerun ./gradlew -PvendoredDependenciesOnly -Ppublishing -PjavaLinkageArtifactIds=beam-vendor-calcite-1_20_0:0.2-SNAPSHOT :checkJavaLinkage and compared with linkage error in BEAM-9412. I think there is no major changes

> Task :checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Class org.slf4j.Logger is not found;
  referenced by 59 class files
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.adapter.enumerable.EnumerableAggregateRule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.adapter.jdbc.JdbcRules (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.interpreter.Bindables (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.AbstractRelOptPlanner (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.hep.HepPlanner (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.RelSet (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.RelSubset (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.RuleQueue (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.VolcanoPlanner (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.VolcanoRuleCall (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.prepare.Prepare (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.AbstractRelNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.hint.HintStrategyTable (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.rules.CalcRelSplitter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.CalciteException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.ResultSetEnumerable (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.SqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.dialect.HsqldbSqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.dialect.JethroDataSqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.dialect.MysqlSqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.parser.SqlParserUtil (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.parser.impl.SqlParserImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.validate.SqlValidatorException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.validate.SqlValidatorImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql2rel.RelDecorrelator (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql2rel.RelFieldTrimmer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql2rel.SqlToRelConverter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Benchmark (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Util (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.trace.CalciteLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.trace.CalciteTimingTracer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.jdbc.JdbcMeta (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaJsonHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaProtobufHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaSpnegoAuthenticator (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.DelegatingAvaticaHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HandlerFactory (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HttpServer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.PropertyBasedSpnegoLoginService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.ServerKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientSpnegoImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaHttpClientFactoryImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ClientKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.Driver (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.KerberosConnection (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ProtobufTranslationImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.RemoteProtobufService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.FilterCompiler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.RelationalExpressionNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.ValueNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.JsonContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.ArrayPathToken (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.CompiledPath (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.PredicateContextImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.metrics.MetricsSystemLoader (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.util.log.Slf4jLog (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.slf4j.LoggerFactory is not found;
  referenced by 39 class files
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.RexImplicationChecker (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.VisitorDataContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.rules.AbstractMaterializedViewRule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.CalciteException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.ResultSetEnumerable (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.SqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.SqlDialectFactoryImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.pretty.SqlPrettyWriter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.validate.SqlValidatorException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Benchmark (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.trace.CalciteTrace (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.jdbc.JdbcMeta (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaJsonHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaProtobufHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaSpnegoAuthenticator (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.DelegatingAvaticaHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HandlerFactory (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HttpServer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.PropertyBasedSpnegoLoginService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.ServerKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientSpnegoImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaHttpClientFactoryImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ClientKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.Driver (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.KerberosConnection (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ProtobufTranslationImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.RemoteProtobufService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.FilterCompiler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.RelationalExpressionNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.ValueNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.JsonContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.ArrayPathToken (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.CompiledPath (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.PredicateContextImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.metrics.MetricsSystemLoader (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.util.log.Slf4jLog (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.slf4j.helpers.MessageFormatter is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Litmus (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.slf4j.helpers.FormattingTuple is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Litmus (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.Gson is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.JsonElement is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.JsonPrimitive is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.JsonParser is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.JsonArray is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.JsonObject is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONArray is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONObject is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONException is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONTokener is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.json.JSONException is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.json.JSONTokener is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.json.JSONObject is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.JsonOrgMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.json.JSONArray is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.JsonOrgMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tapestry5.json.JSONObject is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.TapestryJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tapestry5.json.JSONCollection is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.TapestryJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tapestry5.json.JSONArray is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.TapestryJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.TypeAdapter is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class com.google.gson.reflect.TypeToken is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class javax.transaction.RollbackException is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class javax.transaction.SystemException is not found;
  referenced by 2 class files
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionRegistry (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class javax.transaction.Transaction is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class javax.transaction.TransactionSynchronizationRegistry is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class javax.transaction.Synchronization is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class javax.transaction.TransactionManager is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionRegistry (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tools.ant.taskdefs.compilers.DefaultCompilerAdapter is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.janino.AntCompilerAdapter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tools.ant.types.Path is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.janino.AntCompilerAdapter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tools.ant.taskdefs.Javac is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.janino.AntCompilerAdapter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.avalon.framework.logger.Logger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.AvalonLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.log4j.Logger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.Log4JLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.log4j.Level is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.Log4JLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.log4j.Priority is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.Log4JLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.log.Hierarchy is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.LogKitLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.log.Logger is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.LogKitLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.eclipse.jetty.jmx.ObjectMBean is not found;
  referenced by 3 class files
    org.eclipse.jetty.server.jmx.AbstractConnectorMBean (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.server.jmx.ServerMBean (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.server.handler.jmx.AbstractHandlerMBean (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.slf4j.spi.LocationAwareLogger is not found;
  referenced by 2 class files
    org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.eclipse.jetty.util.log.Slf4jLog (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class net.sf.cglib.proxy.MethodInterceptor is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.pool2.proxy.CglibProxyHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class net.sf.cglib.proxy.Enhancer is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.pool2.proxy.CglibProxySource (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class net.sf.cglib.proxy.Factory is not found;
  referenced by 1 class file
    org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.pool2.proxy.CglibProxySource (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)

beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar is at:
  org.apache.beam:beam-vendor-calcite-1_22_0:0.1-SNAPSHOT (compile)

diff https://www.diffchecker.com/JnoAgq4M

lukecwik · 2020-03-05T21:59:37Z

Class net.minidev.json.JSONArray is not found;
Class net.minidev.json.JSONObject is not found;
Class net.minidev.json.JSONStyle is not found;
Class net.minidev.json.JSONValue is not found;
Class net.minidev.json.parser.JSONParser is not found;
Class net.minidev.json.parser.ParseException is not found;
Class net.minidev.json.writer.JsonReaderI is not found;
Class net.minidev.json.writer.JsonReader is not found;

Seem to be new warnings. Is the minidev JSON dependency important/optional/provided?

vectorijk · 2020-03-06T07:16:30Z

yes, it is optional. I reduced the set of linkage errors being reported.

> Task :checkJavaLinkage
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
Class org.apache.tapestry5.ioc.services.Coercion is not found;
  referenced by 2 class files
    org.apache.tapestry5.internal.json.StringToJSONArray (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
    org.apache.tapestry5.internal.json.StringToJSONObject (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tapestry5.ioc.services.CoercionTuple is not found;
  referenced by 1 class file
    org.apache.tapestry5.json.modules.JSONModule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.apache.tapestry5.ioc.Configuration is not found;
  referenced by 1 class file
    org.apache.tapestry5.json.modules.JSONModule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.droidparts.dexmaker.stock.ProxyBuilder is not found;
  referenced by 1 class file
    org.easymock.internal.AndroidClassProxyFactory (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
Class org.junit.jupiter.api.extension.TestInstancePostProcessor is not found;
  referenced by 1 class file
    org.easymock.EasyMockExtension (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)

beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar is at:
  org.apache.beam:beam-vendor-calcite-1_22_0:0.1-SNAPSHOT (compile)

lukecwik · 2020-03-06T16:41:51Z

retest this please

lukecwik · 2020-03-06T16:49:00Z

The vendored jar fails validation. You can rerun the validation locally with

./gradlew -p vendor/calcite-1_22_0 check

Your shading without relocating lots of classes, such as:

org/objectweb/asm/AnnotationVisitor.class
org/objectweb/asm/AnnotationWriter.class
org/objectweb/asm/Attribute$Set.class
org/objectweb/asm/Attribute.class
org/objectweb/asm/ByteVector.class
org/objectweb/asm/ClassReader.class
org/objectweb/asm/ClassTooLargeException.class
org/objectweb/asm/ClassVisitor.class
org/objectweb/asm/ClassWriter.class
org/objectweb/asm/ConstantDynamic.class
org/objectweb/asm/Constants.class
org/objectweb/asm/Context.class

The above command will enumerate them all.

vectorijk · 2020-03-06T21:45:19Z

looking these classes without relocating

vectorijk · 2020-03-09T18:22:16Z

fixed and passed vendored jar validation

amaliujia · 2020-03-09T18:33:24Z

retest this please

amaliujia · 2020-03-09T18:33:42Z

Thank you @vectorijk.

I will merge this PR after tests pass.

amaliujia · 2020-03-09T18:41:49Z

retest this please

lukecwik · 2020-03-09T18:40:02Z

vendor/calcite-1_22_0/build.gradle

+        "org.objectweb",
+        "org.objenesis",
+        "org.pentaho",
+        "org.slf4j",


If you relocate logging, you will lose all logging from this vendored library.

Consider not relocating them and marking them as runtime depedencies.

move logging library as runtime dependencies

lukecwik · 2020-03-09T18:41:56Z

vendor/calcite-1_22_0/build.gradle

+                "org.testng:testng:7.1.0",
+        ],
+        runtimeDependencies: [
+                "com.jayway.jsonpath:json-path:2.4.0",


Why are you relocating com.jayway and marking json-path as a runtime dependency?

Ditto for other libraries below such as commons-logging, antlr, slf4j

move antlr to dependencies and relocate it and not relocate commons-logging and slf4j

amaliujia · 2020-03-09T22:14:05Z

Since shading/vendoring seems need more knowledge to do it right, I will also try to test this PR once I have some time this week.

stale · 2020-06-21T05:15:43Z

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

stale · 2020-06-28T12:30:57Z

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

kennknowles · 2020-09-29T18:21:20Z

Now there is a PR for a newer version of Calcite, we can work together there possible. #12962

vendor calcite 1.22.0

661ad4f

probot-autolabeler bot added build vendor labels Mar 5, 2020

amaliujia approved these changes Mar 5, 2020

View reviewed changes

vectorijk mentioned this pull request Mar 5, 2020

[Hotfix] fix rabbitmp spotless check #11059

Merged

fix linkage

fe53232

vectorijk added 3 commits March 7, 2020 21:00

fix validate vendoring

1bc56ea

sort lines alphabetically

b5022b0

fix

0d87a15

vectorijk changed the title ~~[SQL] vendor calcite 1.22.0~~ [BEAM-9379] vendor calcite 1.22.0 Mar 9, 2020

lukecwik requested changes Mar 9, 2020

View reviewed changes

vectorijk added 4 commits April 12, 2020 21:20

address some comments

c8e6676

fix

8db3db6

fix check

8cc7aab

fix comments

4780006

vectorijk added 2 commits April 21, 2020 21:28

Merge branch 'master' into calcite-1-22

261162d

merge BEAM-9765

ba47646

stale bot added the stale label Jun 21, 2020

stale bot closed this Jun 28, 2020

vectorijk mentioned this pull request Sep 30, 2020

[WIP][BEAM-9379] Update calcite to 1.26 #12962

Closed

4 tasks

[BEAM-9379] vendor calcite 1.22.0 #11058

[BEAM-9379] vendor calcite 1.22.0 #11058

Uh oh!

Conversation

vectorijk commented Mar 5, 2020

Pre-Commit Tests Status (on master branch)

Uh oh!

vectorijk commented Mar 5, 2020

Uh oh!

amaliujia commented Mar 5, 2020

Uh oh!

amaliujia commented Mar 5, 2020

Uh oh!

lukecwik commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vectorijk commented Mar 5, 2020

Uh oh!

lukecwik commented Mar 5, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vectorijk commented Mar 6, 2020

Uh oh!

lukecwik commented Mar 6, 2020

Uh oh!

lukecwik commented Mar 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vectorijk commented Mar 6, 2020

Uh oh!

vectorijk commented Mar 9, 2020

Uh oh!

amaliujia commented Mar 9, 2020

Uh oh!

amaliujia commented Mar 9, 2020

Uh oh!

amaliujia commented Mar 9, 2020

Uh oh!

lukecwik Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

vectorijk Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

lukecwik Mar 9, 2020

Choose a reason for hiding this comment

Uh oh!

vectorijk Apr 22, 2020

Choose a reason for hiding this comment

Uh oh!

amaliujia commented Mar 9, 2020

Uh oh!

stale bot commented Jun 21, 2020

Uh oh!

stale bot commented Jun 28, 2020

Uh oh!

kennknowles commented Sep 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lukecwik commented Mar 5, 2020 •

edited

Loading

lukecwik commented Mar 5, 2020 •

edited

Loading

lukecwik commented Mar 6, 2020 •

edited

Loading

kennknowles commented Sep 29, 2020 •

edited

Loading