[BEAM-9147] Make VideoIntelligence use PTransform on user-facing API #11464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Member
Author
|
Run Java PreCommit |
1 similar comment
Member
Author
|
Run Java PreCommit |
jkff
reviewed
Apr 21, 2020
Contributor
jkff
left a comment
jkff
left a comment
There was a problem hiding this comment.
Thanks! On to @chamikaramj .
|
|
||
| /** | ||
| * Base class for Video Intelligence transform. | ||
| * Base class for VideoIntelligence PTransform. |
Contributor
There was a problem hiding this comment.
- PTransforms should almost never need inheritance; based on the usage of this class, it's not needed here either - the current base class serves only the purpose of storing configuration variables, but contains no functionality - these variables can just be packaged into a configuration object, and current subclasses of AnnotateVideo can derive from PTransform directly and each store this configuration object.
- Even if you decide to keep using inheritance, please at least make this class non-public.
Member
Author
There was a problem hiding this comment.
You're right that it wasn't necessary. I got rid of the inheritance.
| this.featureList = featureList; | ||
| } | ||
|
|
||
| @StartBundle |
Contributor
There was a problem hiding this comment.
Should this be in @Setup instead?
Member
Author
There was a problem hiding this comment.
Moved, thanks for the tip
|
@mwalenia Please resolve merge conflicts. |
Member
Author
|
Run Java PreCommit |
mwalenia
force-pushed
the
BEAM-9147-use-ptransforms
branch
from
4fe0d53 to
d8baca4
Compare
Member
Author
|
Run Java PreCommit |
2 similar comments
Member
Author
|
Run Java PreCommit |
Member
Author
|
Run Java PreCommit |
Member
Author
Contributor
|
Yes, feel free to merge. |
yirutang
pushed a commit
to yirutang/beam
that referenced
this pull request
Jul 23, 2020
…pache#11464) [BEAM-9147] Make VideoIntelligence use PTransform on user-facing API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the remark in #11261 I modified the code to be in line with the PTransform creation guide.
Thanks, @jkff for your keen eye!
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.