[BEAM-168] IntervalBoundedExponentialBackOff: add deprecated copy of old API #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
| private final long initialIntervalMillis; | ||
| private int currentAttempt; | ||
|
|
||
| @Deprecated |
Contributor
There was a problem hiding this comment.
Maybe add a comment about why this is around and deprecated?
This fixes a bug submitting jobs to Google Cloud Dataflow service.
Member
|
LGTM |
Contributor
Author
|
Travis passed; merging now. |
dhalperi
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Apr 5, 2016
dhalperi
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Apr 14, 2016
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
#! Remove unnecessary null check, re-use variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.
This fixes a bug submitting jobs to Google Cloud Dataflow service.