Skip to content

Conversation

@omarismail94
Copy link
Contributor

@omarismail94 omarismail94 commented May 18, 2020

R: @TheNeuralBit

Adding work done on BEAM-9964 to CHANGES.md for Beam 2.22 release


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@TheNeuralBit TheNeuralBit changed the title [CHANGES.md] - Adding BEAM-9964 to CHANGES.md for Beam 2.22 [BEAM-9964] Update CHANGES.md May 18, 2020
@TheNeuralBit
Copy link
Member

retest this please

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@TheNeuralBit TheNeuralBit merged commit de9177e into apache:master May 18, 2020
pabloem added a commit that referenced this pull request May 19, 2020
* Support ZetaSQL DATE type as a Beam LogicalType

* [BEAM-6733] Add pipeline option to flush bundle data before checkpointing

We had a couple of PRs in which we wanted to remove the buffering of bundle
output during checkpointing: #7940 #9652. Ultimately, we didn't merge any of
those because we weren't sure how the change would affect the checkpoint
performance.

As a better migration path, this introduces a pipeline option to change the
default, buffering bundle output during checkpointing, to finishing the bundle
and flushing all data before checkpointing.

* Remove all answer placeholder checks as they can be confusing at times for some learners

* Update course in Stepik

* [BEAM-10018] Fix timestamps in windowing kata

In this Kata, the timestamp was calculated from time objects, and converted to a
timestamp in the local timezone. Thus, the results of the test depended on the
configuration of the local timezone in the running system.

The tests were hardcoded with a timezone different to mine, and thus I always
failed to pass this Kata. The changes in this commit change the type in Event to
be a datetime, the timestamps are set in UTC, and the output in the tests is
hardcoded in UTC too. This should ensure that the kata works regardless the
timezone configured in the system running the kata.

* [BEAM-10018] Kata failing due to failed parsing

Parsing the timestamps as strings using fromisoformat was failing, and the Kata
failed silently regardless the code written in the boxes.

This change sets the same timestamps, with UTC timezone, without parsing
strings.

* Convert html task description to md for "Hello Beam" and "Core Transforms/Map"

* Remove unused import

* Add missing dependency

* Fix member variable name in Kata documentation

* Fix placeholder location

* Convert html task description to md for "Core Transforms" remaining lessons

* Convert html task description to md for "Common Transforms" lessons

* Convert html task description to md for remaining Python Katas lessons

* Convert html task description to md for most of Java Katas lessons

* Convert html task description to md for Java Katas "Common Transforms" lessons

* Convert html task description to md for Java Katas "Core Transforms" lessons

* [BEAM-2530] Implement Zeta SQL precommit compile tests and run on java 11 (#11692)

[BEAM-2530] Implement Zeta SQL precommit compile tests and run on java 11

* Python3 fix - convert dict.keys() to list before indexing (#11733)

* Updates google-apitools and httplib2 (#11726)

* [BEAM-9964] Update CHANGES.md  (#11743)

Co-authored-by: Omar Ismail <omarismail@omarismail-macbookpro.roam.corp.google.com>

* [BEAM-9577] Artifact v2 support for uber jars. (#11708)

* Adds a "filesystem" for artifacts placed on the classpath (e.g. within the uberjar).
* Updates the flink and spark uberjars to use artifact staging v2, leveraging the above filesystem.

* Populate all SpannerIO batching parameters in display data.

Add all the grouping/batching parameters in SpannerIO
populateDisplayData().

* Fix capitalization, clarify descriptions

* fix capitalization, clarify description Grouped

* Refactor to extract single method for popuplating displayData

* Convert html task description to md for "Hello Beam" and "Core Transforms/Map"

* Convert html task description to md for "Core Transforms" remaining lessons

* Convert html task description to md for "Common Transforms" lessons

* Convert html task description to md for remaining Python Katas lessons

* Convert html task description to md for most of Java Katas lessons

* Convert html task description to md for Java Katas "Common Transforms" lessons

* Convert html task description to md for Java Katas "Core Transforms" lessons

* Resolve merge conflict

* Update Python Katas on Stepik

* Update Beam Katas Java on Stepik

Co-authored-by: Yueyang Qiu <robinyqiu@gmail.com>
Co-authored-by: Maximilian Michels <mxm@apache.org>
Co-authored-by: Israel Herraiz <ihr@google.com>
Co-authored-by: pawelpasterz <32893017+pawelpasterz@users.noreply.github.com>
Co-authored-by: Chamikara Jayalath <chamikara@apache.org>
Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
Co-authored-by: Pablo <pabloem@users.noreply.github.com>
Co-authored-by: omarismail94 <44980219+omarismail94@users.noreply.github.com>
Co-authored-by: Omar Ismail <omarismail@omarismail-macbookpro.roam.corp.google.com>
Co-authored-by: Andrew Pilloud <apilloud@users.noreply.github.com>
Co-authored-by: Robert Bradshaw <robertwb@google.com>
Co-authored-by: nielm <nielm@google.com>
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
Co-authored-by: Brian Hulette <bhulette@google.com>
@omarismail94 omarismail94 deleted the ChangeMdBeam9964 branch May 19, 2020 23:31
yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
Co-authored-by: Omar Ismail <omarismail@omarismail-macbookpro.roam.corp.google.com>
yirutang pushed a commit to yirutang/beam that referenced this pull request Jul 23, 2020
* Support ZetaSQL DATE type as a Beam LogicalType

* [BEAM-6733] Add pipeline option to flush bundle data before checkpointing

We had a couple of PRs in which we wanted to remove the buffering of bundle
output during checkpointing: apache#7940 apache#9652. Ultimately, we didn't merge any of
those because we weren't sure how the change would affect the checkpoint
performance.

As a better migration path, this introduces a pipeline option to change the
default, buffering bundle output during checkpointing, to finishing the bundle
and flushing all data before checkpointing.

* Remove all answer placeholder checks as they can be confusing at times for some learners

* Update course in Stepik

* [BEAM-10018] Fix timestamps in windowing kata

In this Kata, the timestamp was calculated from time objects, and converted to a
timestamp in the local timezone. Thus, the results of the test depended on the
configuration of the local timezone in the running system.

The tests were hardcoded with a timezone different to mine, and thus I always
failed to pass this Kata. The changes in this commit change the type in Event to
be a datetime, the timestamps are set in UTC, and the output in the tests is
hardcoded in UTC too. This should ensure that the kata works regardless the
timezone configured in the system running the kata.

* [BEAM-10018] Kata failing due to failed parsing

Parsing the timestamps as strings using fromisoformat was failing, and the Kata
failed silently regardless the code written in the boxes.

This change sets the same timestamps, with UTC timezone, without parsing
strings.

* Convert html task description to md for "Hello Beam" and "Core Transforms/Map"

* Remove unused import

* Add missing dependency

* Fix member variable name in Kata documentation

* Fix placeholder location

* Convert html task description to md for "Core Transforms" remaining lessons

* Convert html task description to md for "Common Transforms" lessons

* Convert html task description to md for remaining Python Katas lessons

* Convert html task description to md for most of Java Katas lessons

* Convert html task description to md for Java Katas "Common Transforms" lessons

* Convert html task description to md for Java Katas "Core Transforms" lessons

* [BEAM-2530] Implement Zeta SQL precommit compile tests and run on java 11 (apache#11692)

[BEAM-2530] Implement Zeta SQL precommit compile tests and run on java 11

* Python3 fix - convert dict.keys() to list before indexing (apache#11733)

* Updates google-apitools and httplib2 (apache#11726)

* [BEAM-9964] Update CHANGES.md  (apache#11743)

Co-authored-by: Omar Ismail <omarismail@omarismail-macbookpro.roam.corp.google.com>

* [BEAM-9577] Artifact v2 support for uber jars. (apache#11708)

* Adds a "filesystem" for artifacts placed on the classpath (e.g. within the uberjar).
* Updates the flink and spark uberjars to use artifact staging v2, leveraging the above filesystem.

* Populate all SpannerIO batching parameters in display data.

Add all the grouping/batching parameters in SpannerIO
populateDisplayData().

* Fix capitalization, clarify descriptions

* fix capitalization, clarify description Grouped

* Refactor to extract single method for popuplating displayData

* Convert html task description to md for "Hello Beam" and "Core Transforms/Map"

* Convert html task description to md for "Core Transforms" remaining lessons

* Convert html task description to md for "Common Transforms" lessons

* Convert html task description to md for remaining Python Katas lessons

* Convert html task description to md for most of Java Katas lessons

* Convert html task description to md for Java Katas "Common Transforms" lessons

* Convert html task description to md for Java Katas "Core Transforms" lessons

* Resolve merge conflict

* Update Python Katas on Stepik

* Update Beam Katas Java on Stepik

Co-authored-by: Yueyang Qiu <robinyqiu@gmail.com>
Co-authored-by: Maximilian Michels <mxm@apache.org>
Co-authored-by: Israel Herraiz <ihr@google.com>
Co-authored-by: pawelpasterz <32893017+pawelpasterz@users.noreply.github.com>
Co-authored-by: Chamikara Jayalath <chamikara@apache.org>
Co-authored-by: tvalentyn <tvalentyn@users.noreply.github.com>
Co-authored-by: Pablo <pabloem@users.noreply.github.com>
Co-authored-by: omarismail94 <44980219+omarismail94@users.noreply.github.com>
Co-authored-by: Omar Ismail <omarismail@omarismail-macbookpro.roam.corp.google.com>
Co-authored-by: Andrew Pilloud <apilloud@users.noreply.github.com>
Co-authored-by: Robert Bradshaw <robertwb@google.com>
Co-authored-by: nielm <nielm@google.com>
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
Co-authored-by: Brian Hulette <bhulette@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants