[BEAM-114] Add src distribution #121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
R: @davorbonaci |
| <fileSet> | ||
| <directory>${basedir}</directory> | ||
| <outputDirectory>/</outputDirectory> | ||
| <excludes> |
Member
There was a problem hiding this comment.
Could we add the whole contents of the .gitignore file here?
Also, I'd suggest to add a comment both here and in .gitignore that says that this list should include everything from .gitignore, but may include other things too.
Member
|
Nice -- I didn't know this can be done so cleanly. Left a few comments -- 2 FYI-only, 2 with minor action. |
Member
Author
|
Rebase and update according to @davorbonaci comments. |
| <directory>${basedir}</directory> | ||
| <outputDirectory>/</outputDirectory> | ||
| <excludes> | ||
| <!-- NB: the exclude here should be sync with content of .gitignore --> |
Member
There was a problem hiding this comment.
Add the comment to .gitignore too?
Member
|
LGTM |
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…-from-reduce-by-key apache#121 allow multiple elements from reduce by key
dmvk
pushed a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
dmvk
pushed a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
dmvk
pushed a commit
to dmvk/beam
that referenced
this pull request
May 15, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
mareksimunek
pushed a commit
to seznam/beam
that referenced
this pull request
Jul 9, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Aug 17, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
dmvk
pushed a commit
to seznam/beam
that referenced
this pull request
Oct 5, 2018
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* feat: make collections call backed by async * fix: failing asyncmock assertion * fix: lint * refactor: move AsyncMock to test helpers * feat: integrate microgen async client to collection * fix: lint * feat: integrate microgen async client to document * fix: docstring fixes
becketqin
pushed a commit
to becketqin/beam
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
number, if there is one.
Individual Contributor License Agreement.