Fix misleading Javadoc on Trigger.onElement() #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
R: @mshields822 |
Contributor
|
LGTM, but I can't merge it. I'm not a committer. |
Member
|
LGTM. I'll merge it. |
pl04351820
pushed a commit
to pl04351820/beam
that referenced
this pull request
Dec 20, 2023
* refactor: move generated client instantiation out of base class * feat: integrate microgen async client to client * feat: make collections call backed by async * fix: failing asyncmock assertion * refactor: remove unused install * fix: lint * refactor: shared functionality in client to base class * refactor: move AsyncMock to test helpers * fix: return type in client docs * feat: integrate microgen async client to collection * fix: lint * feat: integrate microgen async client to document * feat: integrate microgen async client to batch * fix: use AsyncMock for batch async tests: * fix: collection and document testing batch
FuRyanf
pushed a commit
to FuRyanf/beam
that referenced
this pull request
Aug 29, 2024
…pache#122) * Fix the repeatively calling toProto() when creating ReduceFniRunner * Update beam version * Fix avro plugin repo --------- Co-authored-by: Xinyu Liu <xiliu@xiliu-mn1.linkedin.biz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been bothering me for a while and I always have to go back to the code to check whether my assumption is right. The comment should now reflect the actual behavior.
I didn't file a Jira for this since it's a very small change. I hope this is alright.