-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-10569] Auto-convert spanner tests. #12360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
R: @mszb |
|
Run Python PreCommit |
|
Run Python 3.8 PostCommit |
TheNeuralBit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just to double-check, did you verify that this test can fail after your change?
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
|
This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time. |
|
Run Python 3.7 PostCommit |
|
Reopened the PR to see what the errors were. cc: @BjornPrime |
|
Looks like for now this is broken on a syntax error: |
|
Run Python 3.7 PostCommit |
|
Run Python 3.7 PostCommit |
1 similar comment
|
Run Python 3.7 PostCommit |
|
Run Python PreCommit |
|
Run PythonFormatter PreCommit |
|
Looks like this was mostly taken care of in #23365 |

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.