Skip to content

Conversation

@robertwb
Copy link
Contributor


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@robertwb
Copy link
Contributor Author

R: @mszb

@TheNeuralBit
Copy link
Member

Run Python PreCommit

@TheNeuralBit
Copy link
Member

Run Python 3.8 PostCommit

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just to double-check, did you verify that this test can fail after your change?

@TheNeuralBit
Copy link
Member

Well I guess it can fail.. looks like the spannerio_test is broken:
image

@stale
Copy link

stale bot commented Nov 7, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Nov 7, 2020
@stale
Copy link

stale bot commented Nov 16, 2020

This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Nov 16, 2020
@tvalentyn tvalentyn reopened this Aug 2, 2022
@tvalentyn
Copy link
Contributor

Run Python 3.7 PostCommit

@tvalentyn
Copy link
Contributor

Reopened the PR to see what the errors were. cc: @BjornPrime

@TheNeuralBit
Copy link
Member

Looks like for now this is broken on a syntax error:

/usr/lib/python3.7/ast.py:35: in parse
    return compile(source, filename, mode, PyCF_ONLY_AST)
E     File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python37_PR/src/sdks/python/apache_beam/io/gcp/experimental/spannerio_test.py", line 340
E       _ = (
E       ^
E   IndentationError: unexpected indent

@tvalentyn
Copy link
Contributor

Run Python 3.7 PostCommit

@tvalentyn
Copy link
Contributor

Run Python 3.7 PostCommit

1 similar comment
@BjornPrime
Copy link
Contributor

Run Python 3.7 PostCommit

@BjornPrime
Copy link
Contributor

Run Python PreCommit

@BjornPrime
Copy link
Contributor

Run PythonFormatter PreCommit

@robertwb
Copy link
Contributor Author

Looks like this was mostly taken care of in #23365

@robertwb robertwb closed this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants