[BEAM-10777] Add two blog posts detailing changes to the type hints module of the Python SDK #12657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
Run Website_Stage_GCS PreCommit |
udim
requested changes
Aug 22, 2020
Member
udim
left a comment
udim
left a comment
There was a problem hiding this comment.
Looks good, I had a few comments.
There's a new whitespace check that's failing. :(
website/www/site/content/en/blog/python-improved-annotations.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-improved-annotations.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-improved-annotations.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
website/www/site/content/en/blog/python-performance-runtime-type-checking.md
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks, pushed some changes. PTAL when you have the chance |
udim
approved these changes
Aug 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.