Skip to content

Conversation

@kileys
Copy link
Contributor

@kileys kileys commented Oct 12, 2020

Use GCP libraries bom to set versions for GCP related libraries

Updated version of #11156

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@kileys
Copy link
Contributor Author

kileys commented Oct 12, 2020

Run Java examples on Dataflow Java 11

@kileys
Copy link
Contributor Author

kileys commented Oct 12, 2020

Run Dataflow ValidatesRunner Java 11

@kileys kileys closed this Oct 12, 2020
@kileys kileys reopened this Oct 12, 2020
@kileys
Copy link
Contributor Author

kileys commented Oct 12, 2020

Run Dataflow ValidatesRunner

@kileys
Copy link
Contributor Author

kileys commented Oct 12, 2020

Run Java PostCommit

@github-actions
Copy link
Contributor

The Build Workflow run is cancelling this PR. It in earlier duplicate of 2173354 run.

@kennknowles
Copy link
Member

Run Spotless PreCommit

@kennknowles
Copy link
Member

I don't see any reason for that strange error in spotless.

@kileys
Copy link
Contributor Author

kileys commented Oct 13, 2020

Run Python PreCommit

@kileys
Copy link
Contributor Author

kileys commented Oct 13, 2020

Run Python_PVR_Flink PreCommit

@kileys
Copy link
Contributor Author

kileys commented Oct 15, 2020

Run Spark ValidatesRunner

@kileys
Copy link
Contributor Author

kileys commented Oct 15, 2020

Run Dataflow ValidatesRunner

@kileys
Copy link
Contributor Author

kileys commented Oct 15, 2020

@suztomo are there other tests I should run to verify this? Linkage checker runs without any new errors

@kileys
Copy link
Contributor Author

kileys commented Oct 15, 2020

R: @kennknowles, @suztomo, @lukecwik

@kileys
Copy link
Contributor Author

kileys commented Oct 15, 2020

The Dataflow validates runner tests are also failing on master

Copy link
Contributor

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there other tests I should run to verify this?

Not that I know of.

@lukecwik
Copy link
Member

Also, it seems as though existing modules that don't add a platform level dep to the GCP libraries bom will get some version of the dep since we have cleared the version.

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kileys
Copy link
Contributor Author

kileys commented Oct 30, 2020

Run Java PreCommit

@kileys
Copy link
Contributor Author

kileys commented Oct 30, 2020

Run Python PreCommit

@kileys
Copy link
Contributor Author

kileys commented Oct 30, 2020

Run Java_Examples_Dataflow PreCommit

@kennknowles
Copy link
Member

It does seem that if a module had any of these deps but forgot the enforcedPlatform line then it would go back to getting the arbitrary latest version. I understand fixing that is in a follow-up.

Here's what I did to view the dep changes:

# gcp is GNU cp here
mkdir ~/tmp/deps-before
git checkout github/master
./gradlew dependencyReport
find . -name dependencies.txt -exec gcp --parents \{\} ~/tmp/deps-before/ \;

mkdir ~/tmp/deps-after
git checkout github/pr/13075
./gradlew dependencyReport
find . -name dependencies.txt -exec gcp --parents \{\} ~/tmp/deps-after/ \;

diff --brief --recursive ~/tmp/deps-before ~/tmp/deps-after

diff --unified=0 --recursive ~/tmp/deps-before ~/tmp/deps-after

Copy link
Member

@kennknowles kennknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have the capacity to manually determine the possible consequences of the dep changes, which do affect modules not listed (for example autovalue annotations are downgraded a couple patch versions).

I was checking just for modules that were accidentally "upgraded" to the latest by not having a version or that were accidentally downgraded because the BOM reduced versions they depended on that had nothing to do with GCP. I did not find any problems, but it is too much content to be certain. Still, it is surely an improvement.

@kennknowles kennknowles merged commit c0c39eb into apache:master Nov 2, 2020
@kileys kileys deleted the beam-9444-bom branch November 19, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants