-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-9444] Use GCP BOM to set package versions #13075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Java examples on Dataflow Java 11 |
|
Run Dataflow ValidatesRunner Java 11 |
|
Run Dataflow ValidatesRunner |
|
Run Java PostCommit |
|
The Build Workflow run is cancelling this PR. It in earlier duplicate of 2173354 run. |
|
Run Spotless PreCommit |
|
I don't see any reason for that strange error in spotless. |
|
Run Python PreCommit |
|
Run Python_PVR_Flink PreCommit |
|
Run Spark ValidatesRunner |
|
Run Dataflow ValidatesRunner |
|
@suztomo are there other tests I should run to verify this? Linkage checker runs without any new errors |
|
The Dataflow validates runner tests are also failing on master |
suztomo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there other tests I should run to verify this?
Not that I know of.
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
Outdated
Show resolved
Hide resolved
|
Also, it seems as though existing modules that don't add a platform level dep to the GCP libraries bom will get some version of the dep since we have cleared the version. |
kennknowles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Run Java PreCommit |
|
Run Python PreCommit |
|
Run Java_Examples_Dataflow PreCommit |
|
It does seem that if a module had any of these deps but forgot the Here's what I did to view the dep changes: |
kennknowles
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not have the capacity to manually determine the possible consequences of the dep changes, which do affect modules not listed (for example autovalue annotations are downgraded a couple patch versions).
I was checking just for modules that were accidentally "upgraded" to the latest by not having a version or that were accidentally downgraded because the BOM reduced versions they depended on that had nothing to do with GCP. I did not find any problems, but it is too much content to be certain. Still, it is surely an improvement.
Use GCP libraries bom to set versions for GCP related libraries
Updated version of #11156
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.