Skip to content

Conversation

@bntnam
Copy link
Contributor

@bntnam bntnam commented Nov 23, 2020

Home page:

  • Implemented new component "Stay up to date with Beam"
  • Changed "Works with" component

Note: Copies/Texts will be updated later by Gris or the community. For now, it's just the implementation of the design.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@bntnam bntnam force-pushed the website/home-page-stay-up-to-date-component branch from 1b9f697 to 8f6802c Compare November 23, 2020 13:24
@bntnam
Copy link
Contributor Author

bntnam commented Nov 23, 2020

Review: @TheNeuralBit

@bntnam bntnam changed the title Website/home page stay up to date component [BEAM-11182][Website revamp] Implemented Stay up to date with Beam and Changed Works with components Nov 23, 2020
@TheNeuralBit TheNeuralBit self-requested a review November 23, 2020 17:08
Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add TODOs around text that's just a placeholder demonstrating the design? That way we won't forgot to swap it out before merging to master

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, will this data be pulled from recent blog posts, or will we have to keep it up to date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that you asked. Yeah, in the future, we'll have a separate stage for functionality improvement (the current stage is about design implementation). And the event will be synced with the event page (which will be implemented later).

Copy link
Member

@TheNeuralBit TheNeuralBit Nov 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between files like this (i18n/**/en.yaml), and the miscellaneous en directories in data? AFAICT the difference is just that i18n just has simpler id - translation pairs while the config in data can be more complex and structured.

Based on that distinction it seems like much of this would be more appropriate in data

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. What I understand is, i18n directory is naturally offered by the Hugo plugin with the same name and it's used for localizing strings, syntax {{ i18n "id here" }} or {{ T "id here" }}. First, I got stuck when I needed to use a loop structure, plus translation together. Then I figured out that data let me to apply a loop structure on it as an array, and i18n helped me to separate directories according to the main language (data/en, data/pl, data/sp, etc.). I know it's a bit annoying to have 2 places, but simply think that one for strings and one for arrays. 😛

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. It seems like with that pattern home-calendar* items could be represented in data with a structure like:

home-calendar-first:
- category-tag: "Category"
- category-date: "2020/02/21"
- card-title: "Performance-Driven Runtime Type Checking for the Python SDK"
- card-author: "Saavan Nanavati"

@bntnam bntnam force-pushed the website/home-page-stay-up-to-date-component branch from d2abcfb to 08e64f3 Compare November 24, 2020 04:24
@bntnam bntnam force-pushed the website/home-page-stay-up-to-date-component branch from 59f91a8 to afcd0f5 Compare November 24, 2020 04:41
@bntnam bntnam force-pushed the website/home-page-stay-up-to-date-component branch from afcd0f5 to 43555be Compare November 24, 2020 04:59
@bntnam
Copy link
Contributor Author

bntnam commented Nov 24, 2020

Added comments and resolved conflicts

Copy link
Member

@TheNeuralBit TheNeuralBit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more questions, but they don't need to block merging

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. It seems like with that pattern home-calendar* items could be represented in data with a structure like:

home-calendar-first:
- category-tag: "Category"
- category-date: "2020/02/21"
- card-title: "Performance-Driven Runtime Type Checking for the Python SDK"
- card-author: "Saavan Nanavati"

url: #
- title: This is the title
place: Data Con LA
time: 2020/02/21
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible for the dates to be represented as some kind of timestamp literal that can be internationalized? For example in the US we usually write dates with the year last - 02/21/2020. Or we may want to have the option to spell out the date in the future.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted. Thanks for your feedback. Let me tell my PM to add them into Jira.

@TheNeuralBit TheNeuralBit merged commit 1f790fc into apache:website-revamp Nov 25, 2020
@TheNeuralBit
Copy link
Member

TheNeuralBit commented Nov 25, 2020

FYI @bntnam I just merged master into website-revamp (0850259) to make sure we don't get too far out of sync.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants