[BEAM-11466-11465-11464-11463-11462][Website revamp] Implemented footer, button bar, calendar, blog, blog post and documentation page #13596
Conversation
|
Review @kgabryje |
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
HTML/CSS looks pretty good overall, just a few minor comments.
I'm a little wary about all the added SVGs, are they all original? It seems like at least the logos may have some copyright.
Also it looks like the website may be failing to build on Jenkins, see the Website and Website_Stage_GCS Precommits.
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
A few requests for this one
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
…deaInternal/beam into homepage-blog-documentation
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Just noticed this issue now that the quotes have been updated.
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
I looked over the documentation/general page and noticed a few rendering issues. Also have one comment on the change to the blog post template.
|
When I looked at the output for this PR before, the navigation was centered. Now it's left justified (as it was in the two recently merged PRs).: Is this intentional? It think it may be a bad merge |
Jakub-Sadowski
left a comment
Jakub-Sadowski
left a comment
There was a problem hiding this comment.
When I looked at the output for this PR before, the navigation was centered. Now it's left justified (as it was in the two recently merged PRs).:
Is this intentional? It think it may be a bad merge
Yes, It's intentional.
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
LGTM, thank you @Jakub-Sadowski!
3 participants
Implemented:
footer, calendar, button bar on home page
blog page and single blog post page
documentation page
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.