-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-11569] Enabling wheels to be built using Apache-based workflow #13674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
r: @lostluck Per @potiuk's comment on https://issues.apache.org/jira/browse/BEAM-11569, this should enable us to build the wheels for the release. Thoughts Rebo? |
|
LGTM |
|
Just one more update! We found a better solution. Submodules. They seem to pass all the security requirements from infra, and they are very easy to add and maintain (and you avoid code duplication). You can see the PR we run to have POC in Airflow: apache/airflow#13514 And disucssion at builds@a.o https://lists.apache.org/thread.html/rcf7f560dad70ed02d77ad131a670e24eb815e41f92a442a3153da98b%40%3Cbuilds.apache.org%3E Jus to quote my words from the discussion: This seems to works perfectly:
We are going to migrate to it in Airflow today/tomorrow and we highly recommend this approach. |
|
BTW. I am going to delete or archive those repositories which I created so maybe even better if you switch to the submodules and use the original repo rather than airflow-'s copy :) |
|
ok thanks for mentioning that. Are you archiving them pretty soon? |
I might leave them lying for a while in archived status :). But it should be super easy to switch. We are doing it in Airflow now: https://github.com/apache/airflow/pull/13514/files |
|
cool cool - will do. thanks. |
|
We're hoping to delete these repos next week https://lists.apache.org/thread.html/r19149c3e8afc04c679ca4091c40447b6d8c7e1be7c9c8660d9975e90%40%3Cdev.airflow.apache.org%3E |
|
alright, I'll make the change today. |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.