[BEAM-11518-11509-11470][Website revamp] Implemented searchbar, join beam page and navigations #13718
Conversation
|
Review: @TheNeuralBit |
|
It looks like you've removed the .gitignore and checked in all the files in the |
ohh yea I will fix this, sorry |
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
This LGTM, aside from the content. I don't think "Stalk Us" is the final copy. Please update with final copy from @griscz or add a TODO.
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Thank you @Jakub-Sadowski. I have a few comments on the new copy, mostly it looks like there's supposed to be links in several places.
| - list: | ||
| - Check out the ways you can become a commiter | ||
| - Here is a document that you should read | ||
| - { title: Learn about the Project Management Committee (PMC), description: The Project Management Committee (PMC) is the highest recognition in Apache projects. If you’re interested in becoming part of it, learn more about it here. } |
There was a problem hiding this comment.
"read how to become a committer" and "learn more about it here" in the PMC section should have links to those documents.
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
This LGTM right now, but there are some merge conflicts now that #11351 is merged. Can you resolve those? Then I'll take another quick look
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
LGTM, just a few tweaks to the links, I'll push them myself.
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
|
Run Website_Stage_GCS PreCommit |
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Sorry I had a typo, in my changes. One more patch
Co-authored-by: Brian Hulette <hulettbh@gmail.com>
2 participants
Implemented:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.