Metric updates for FhirIO: Fix metrics + namings to be consistent. #13792
Conversation
|
I believe the failure in "Run Java PreCommit" is a flake, I was unable to reproduce it. |
|
R: @pabloem |
|
Run Java PreCommit |
|
thanks @msbukal - these will be useful to debug jobs, and may be useful for perf tests if they're ever implemented. |
|
Run Java PreCommit |
|
this is clearly an unrelated flake. FWIW, this change LGTM, so no more action needed from you @msbukal I'll rerun presubmits until we get a green run |
|
Run Java PreCommit |
| private final Counter SEARCH_RESOURCE_SUCCESS = | ||
| Metrics.counter( | ||
| SearchResourcesFn.class, BASE_METRIC_PREFIX + "search_resource_success_count"); | ||
| private final Distribution SEARCH_RESOURCE_LATENCY_MS = |
There was a problem hiding this comment.
Oh there seems to be a style error for these variables. They should be static, or not capitalized. fyi: @msbukal
[ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Phrase/src/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:1614:31: Name 'SEARCH_RESOURCE_ERRORS' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MemberName] |
| [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Phrase/src/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:1617:31: Name 'SEARCH_RESOURCE_SUCCESS' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MemberName] |
| [ant:checkstyle] [ERROR] /home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Phrase/src/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java:1620:36: Name 'SEARCH_RESOURCE_LATENCY_MS' must match pattern '^[a-z][a-zA-Z0-9]*$'. [MemberName]
Usually, when a unit test fails, it is displayed directly in Jenkins. In this case it wasn't, because it was something else failing.
To find these kinds of errors, you can open PreCommit, and then open the Gradle Build Scan, which will point you to the failing task.
There was a problem hiding this comment.
Ah I see, these fields can't be static because of the template (keep going round & round in errors due to this) which means that the metric fields can't be static.
I've renamed them.
Codecov Report
@@ Coverage Diff @@
## master #13792 +/- ##
=======================================
Coverage 82.76% 82.77%
=======================================
Files 466 466
Lines 57558 57558
=======================================
+ Hits 47638 47641 +3
+ Misses 9920 9917 -3
Continue to review full report at Codecov.
|
|
precommit error is unrelated (in fact, it's my fault in a different PR) - I'll merge once I fix precommit on master |
|
closing and opening hoping to retrigger the tests and the merge at the top of master (since now it has the fix for the breakage) |
|
Run Java PreCommit |
1 similar comment
|
Run Java PreCommit |
2 participants
Add success, failure and latency metrics to FHIRIO read, execute bundle and search methods.
Update metric naming to adhere to a consistent standard, and fixed incorrect metric names (eg. "successful-hl7v2-message-gets" for FhirIO.Read).
Update latency measurements to recommended java 8 time approach (java.time.Instant)
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.