Skip to content

Conversation

@ibzib
Copy link

@ibzib ibzib commented Jan 27, 2021

This doesn't erase https://repo.spring.io/plugins-release because it is still used by Gradle plugins.

// Define the set of repositories required to fetch and enable plugins.
repositories {
jcenter()
maven { url "https://plugins.gradle.org/m2/" }
maven {
url "https://repo.spring.io/plugins-release/"
content { includeGroup "io.spring.gradle" }
}
}


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status Build Status Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@ibzib
Copy link
Author

ibzib commented Jan 27, 2021

R: @chamikaramj

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@ibzib
Copy link
Author

ibzib commented Jan 27, 2021

There are still a bunch of errors when I run ./gradlew updateOfflineRepository: BEAM-11701

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #13823 (870cc22) into master (ed5b117) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13823      +/-   ##
==========================================
- Coverage   82.77%   82.77%   -0.01%     
==========================================
  Files         466      466              
  Lines       57557    57557              
==========================================
- Hits        47644    47641       -3     
- Misses       9913     9916       +3     
Impacted Files Coverage Δ
...eam/runners/portability/fn_api_runner/fn_runner.py 89.87% <ø> (ø)
...apache_beam/runners/portability/portable_runner.py 74.55% <ø> (ø)
.../runners/portability/fn_api_runner/translations.py 89.11% <0.00%> (-0.62%) ⬇️
sdks/python/apache_beam/io/iobase.py 84.55% <0.00%> (-0.27%) ⬇️
...ks/python/apache_beam/runners/worker/sdk_worker.py 89.69% <0.00%> (-0.16%) ⬇️
sdks/python/apache_beam/runners/common.py 88.87% <0.00%> (+0.14%) ⬆️
sdks/python/apache_beam/io/source_test_utils.py 89.63% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4edb26f...870cc22. Read the comment docs.

@ibzib
Copy link
Author

ibzib commented Jan 27, 2021

Run Java_Examples_Dataflow PreCommit

@chamikaramj
Copy link
Contributor

Can you send a cherry-pick to 2.28.0 branch as well ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants